Added unit annotation supports onto tsmon in go.

common/tsmon/metric/standard_metrics.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package metric
 
 import (
         "strings"
         "time"
 
         "golang.org/x/net/context"
 
         "github.com/luci/luci-go/common/tsmon/distribution"
         "github.com/luci/luci-go/common/tsmon/field"
+        "github.com/luci/luci-go/common/tsmon/types"
 )
 
 // Metrics common to all tasks and devices.
 var (
         presenceMetric = NewBool(
                 "presence/up",
-                "Set to True when the program is running, missing otherwise.")
+                "Set to True when the program is running, missing otherwise.",
+                types.MetricMetadata{})
 )
 
 // Standard metrics for all requests to remote endpoints.  These
 // metrics should be consistent across all tsmon implementations,
 // Python or Go.
 var (
         requestBytesMetric = NewCumulativeDistribution(
                 "http/request_bytes",
                 "Bytes sent per http request (body only).",
+                types.MetricMetadata{Units: types.Bytes},
                 distribution.DefaultBucketer,
                 field.String("name"),   // Usually the requested service name
                 field.String("client")) // http client used, e.g. urlfetch
 
         responseBytesMetric = NewCumulativeDistribution(
                 "http/response_bytes",
                 "Bytes received per http request (content only).",
+                types.MetricMetadata{Units: types.Bytes},
                 distribution.DefaultBucketer,
                 field.String("name"),   // Usually the requested service name
                 field.String("client")) // http client used, e.g. urlfetch
 
         requestDurationsMetric = NewCumulativeDistribution(
                 "http/durations",
                 "Time elapsed between sending a request and getting a response (including parsing) in milliseconds.",
+                types.MetricMetadata{Units: types.Milliseconds},
                 distribution.DefaultBucketer,
                 field.String("name"),   // Usually the requested service name
                 field.String("client")) // http client used, e.g. urlfetch
 
         responseStatusMetric = NewCounter(
                 "http/response_status",
                 "Number of responses received by HTTP status code.",
+                types.MetricMetadata{},
                 field.Int("status"),    // HTTP status code
                 field.String("name"),   // Usually the requested service name
                 field.String("client")) // http client used, e.g. urlfetch
 )
 
 // Standard metrics for server-side request handlers.  These metrics
 // should be consistent across all tsmon implementations, Python or
 // Go.
 var (
         serverRequestBytesMetric = NewCumulativeDistribution(
                 "http/server_request_bytes",
                 "Bytes received per http request (body only).",
+                types.MetricMetadata{Units: types.Bytes},
                 distribution.DefaultBucketer,
                 field.Int("status"),    // HTTP status code
                 field.String("name"),   // URL template
                 field.Bool("is_robot")) // If request is made by a bot
 
         serverResponseBytesMetric = NewCumulativeDistribution(
                 "http/server_response_bytes",
                 "Bytes sent per http request (body only).",
+                types.MetricMetadata{Units: types.Bytes},
                 distribution.DefaultBucketer,
                 field.Int("status"),    // HTTP status code
                 field.String("name"),   // URL template
                 field.Bool("is_robot")) // If request is made by a bot
 
         serverDurationsMetric = NewCumulativeDistribution(
                 "http/server_durations",
                 "Time elapsed between receiving a request and sending a response (including parsing) in milliseconds.",
+                types.MetricMetadata{Units: types.Milliseconds},
                 distribution.DefaultBucketer,
                 field.Int("status"),    // HTTP status code
                 field.String("name"),   // URL template
                 field.Bool("is_robot")) // If request is made by a bot
 
         serverResponseStatusMetric = NewCounter(
                 "http/server_response_status",
                 "Number of responses sent by HTTP status code.",
+                types.MetricMetadata{},
                 field.Int("status"),    // HTTP status code
                 field.String("name"),   // URL template
                 field.Bool("is_robot")) // If request is made by a bot
 
 )
 
 // UpdatePresenceMetrics sets the presence/up metric.
 func UpdatePresenceMetrics(ctx context.Context) {
         presenceMetric.Set(ctx, true)
 }
@@ skipping 17 matching lines @@
         userAgent string) {
         isRobot := (strings.Contains(userAgent, "GoogleBot") ||
                 strings.Contains(userAgent, "GoogleSecurityScanner") ||
                 userAgent == "B3M/prober")
         serverDurationsMetric.Add(ctx, duration.Seconds()*millisecondsInASecond,
                 code, name, isRobot)
         serverResponseStatusMetric.Add(ctx, 1, code, name, isRobot)
         serverRequestBytesMetric.Add(ctx, float64(requestBytes), code, name, isRobot)
         serverResponseBytesMetric.Add(ctx, float64(responseBytes), code, name, isRobot)
 }