Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 212383002: Drop empty list :host() and :host-context(). (Closed)

Created:
6 years, 9 months ago by rune
Modified:
6 years, 9 months ago
Reviewers:
TabAtkins, dglazkov
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Drop empty list :host() and :host-context(). The <compound-selector> argument may not be empty according to spec. BUG=356578 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -24 lines) Patch
A LayoutTests/fast/dom/shadow/host-context-pseudo-class-css-text.html View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/host-context-pseudo-class-css-text-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/host-pseudo-class-css-text.html View 2 chunks +2 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/shadow/host-pseudo-class-css-text-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSGrammar.y View 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rune
6 years, 9 months ago (2014-03-26 08:05:34 UTC) #1
dglazkov
lgtm
6 years, 9 months ago (2014-03-26 16:30:40 UTC) #2
rune
The CQ bit was checked by rune@opera.com
6 years, 9 months ago (2014-03-26 17:05:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/212383002/1
6 years, 9 months ago (2014-03-26 17:05:45 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 18:10:01 UTC) #5
Message was sent while issue was closed.
Change committed as 170081

Powered by Google App Engine
This is Rietveld 408576698