tools/metrics/histograms/histograms.xml - Issue 2123813002: Report Precache.TimeSinceLastPrecache

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2123813002: Report Precache.TimeSinceLastPrecache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Raj's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 1519047831fff0b41e65960d9ec3c19b55aa7d12..e8f8ffad2222eefb4de6b2c386e690dc804fd103 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -42576,6 +42576,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Precache.TimeSinceLastPrecache" units="minutes">

rkaplow 2016/07/06 21:52:12 it looks like you're subtracting timestamps, which

jamartin 2016/07/07 12:12:36 As you say, we are reporting a base::TimeDelta. Ho

rkaplow 2016/07/07 15:01:34 There's no logic behind the 'units' tag here - it'

+ <owner>jamartin@chromium.org</owner>

+ <owner>bengr@chromium.org</owner>

+ <summary>

+ The time between the the beginning of the last precache session and each of

+ the URL fetches made by the user ever since. Logged per-request.

+ </summary>

+</histogram>

<owner>rkaplow@chromium.org</owner>

<summary>The amount of time that elapsed during CreateProfilePrefs.</summary>