Report Precache.TimeSinceLastPrecache

components/precache/core/precache_session_table.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/precache/core/precache_session_table.h"
 
+#include <stdint.h>
 #include <string>
 
 #include "base/logging.h"
+#include "base/numerics/safe_conversions.h"
 #include "base/time/time.h"
+#include "components/precache/core/proto/timestamp.pb.h"
 #include "components/precache/core/proto/unfinished_work.pb.h"
 #include "sql/connection.h"
 #include "sql/statement.h"
 
 using sql::Statement;
 
 namespace precache {
 
 PrecacheSessionTable::PrecacheSessionTable() : db_(nullptr) {}
 
 PrecacheSessionTable::~PrecacheSessionTable() {}
 
 bool PrecacheSessionTable::Init(sql::Connection* db) {
   DCHECK(!db_);  // Init must only be called once.
   DCHECK(db);    // The database connection must be non-NULL.
   db_ = db;
   return CreateTableIfNonExistent();
 }
 
+void PrecacheSessionTable::SetLastPrecacheTimestamp(const base::Time& time) {
+  Timestamp timestamp;
+  timestamp.set_seconds(base::saturated_cast<int64_t>(time.ToDoubleT()));

[twifkak, 2016/07/08 23:47:53]

Nit: I think `(time - base::Time::UnixEpoch()).InSeconds()` would avoid the
int64->double->int64 casts and express its meaning better.

[jamartin, 2016/07/12 14:18:44]

Done.

+  Statement statement(db_->GetCachedStatement(
+      SQL_FROM_HERE,
+      "INSERT OR REPLACE INTO precache_session (type, value) VALUES(?,?)"));
+  statement.BindInt(0, static_cast<int>(LAST_PRECACHE_TIMESTAMP));
+  statement.BindString(1, timestamp.SerializeAsString());
+  statement.Run();
+}
+
+base::Time PrecacheSessionTable::GetLastPrecacheTimestamp() {
+  Statement statement(db_->GetCachedStatement(
+      SQL_FROM_HERE, "SELECT value from precache_session where type=?"));
+  statement.BindInt(0, static_cast<int>(LAST_PRECACHE_TIMESTAMP));
+  Timestamp timestamp;
+  if (statement.Step())
+    timestamp.ParseFromString(statement.ColumnString(0));
+  return base::Time::FromDoubleT(timestamp.seconds());

[twifkak, 2016/07/08 23:47:53]

Likewise, this could become `base::Time::UnixEpoch() +
base::TimeDelta::FromSeconds(timestamp.seconds())`.

[jamartin, 2016/07/12 14:18:44]

Done.

+}
+
+void PrecacheSessionTable::DeleteLastPrecacheTimestamp() {
+  Statement statement(db_->GetCachedStatement(
+      SQL_FROM_HERE, "DELETE FROM precache_session where type=?"));
+  statement.BindInt(0, static_cast<int>(LAST_PRECACHE_TIMESTAMP));
+  statement.Run();
+}
+
 // Store unfinished work.
 void PrecacheSessionTable::SaveUnfinishedWork(
     std::unique_ptr<PrecacheUnfinishedWork> unfinished_work) {
   Statement statement(db_->GetCachedStatement(
       SQL_FROM_HERE,
       "INSERT OR REPLACE INTO precache_session (type, value) VALUES(?,?)"));
   statement.BindInt(0, static_cast<int>(UNFINISHED_WORK));
   statement.BindString(1, unfinished_work->SerializeAsString());
   statement.Run();
 }
@@ skipping 21 matching lines @@
   statement.Run();
 }
 
 bool PrecacheSessionTable::CreateTableIfNonExistent() {
   return db_->Execute(
       "CREATE TABLE IF NOT EXISTS precache_session (type INTEGER PRIMARY KEY, "
       "value STRING)");
 }
 
 }  // namespace precache