Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2123803003: Remove WinXP hook for OPENFILENAME (Closed)

Created:
4 years, 5 months ago by Patrick Monette
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WinXP hook for OPENFILENAME It is not needed since Windows XP is deprecated. Committed: https://crrev.com/75cd613f013a2dacd3b1fc59e1f6d34bda4cbb05 Cr-Commit-Position: refs/heads/master@{#403948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -76 lines) Patch
M chrome/utility/ipc_shell_handler_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/win/open_file_name_win.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/base/win/open_file_name_win.cc View 2 chunks +0 lines, -67 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Patrick Monette
PTAL
4 years, 5 months ago (2016-07-05 22:01:58 UTC) #2
sky
Please update description as to why you're doing this (XP is dead).
4 years, 5 months ago (2016-07-06 19:22:47 UTC) #3
sky
LGTM
4 years, 5 months ago (2016-07-06 19:22:51 UTC) #4
Patrick Monette
Thanks!
4 years, 5 months ago (2016-07-06 19:26:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123803003/1
4 years, 5 months ago (2016-07-06 19:27:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 20:42:02 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 20:42:26 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 20:43:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75cd613f013a2dacd3b1fc59e1f6d34bda4cbb05
Cr-Commit-Position: refs/heads/master@{#403948}

Powered by Google App Engine
This is Rietveld 408576698