Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2123803002: Remove EventListenerOptions LayoutTests (Closed)

Created:
4 years, 5 months ago by Rick Byers
Modified:
4 years, 5 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove EventListenerOptions LayoutTests They are now redundant with the equivalent web-platform-tests: dom/events/EventListenerOptions-capture.html dom/events/AddEventListenerOptions-passive.html Our policy is not to have redundant LayoutTest coverage for things that are best tested in web-platform-tests. BUG=543685 Committed: https://crrev.com/49d3c4afbc9304e52300e6d95b3a0aed45fbb76a Cr-Commit-Position: refs/heads/master@{#403925}

Patch Set 1 : test to verify that tryjobs actually fail #

Patch Set 2 : Real CL for review #

Messages

Total messages: 10 (5 generated)
Rick Byers
Dave, PTAL See the test results in PS1 that prove the CQ would catch regressions ...
4 years, 5 months ago (2016-07-06 14:39:35 UTC) #2
dtapuska
On 2016/07/06 14:39:35, Rick Byers wrote: > Dave, PTAL > > See the test results ...
4 years, 5 months ago (2016-07-06 14:44:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123803002/20001
4 years, 5 months ago (2016-07-06 14:45:53 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-06 17:26:50 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 17:28:11 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49d3c4afbc9304e52300e6d95b3a0aed45fbb76a
Cr-Commit-Position: refs/heads/master@{#403925}

Powered by Google App Engine
This is Rietveld 408576698