Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2123793002: cc: Don't always rebuild property trees in LayerImplTests (Closed)

Created:
4 years, 5 months ago by ajuma
Modified:
4 years, 5 months ago
Reviewers:
weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews, jaydasika, sunxd
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Don't always rebuild property trees in LayerImplTests Currently, the macros used for testing when draw properties need updates always rebuild property trees. However, in cases where we depend on information in property trees in order to decide whether a draw property update is needed, rebuilding property trees can cause us to test the wrong thing. This CL removes the automatic rebuilding and makes callers responsible for rebuilding when needed. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/3a011ab449665cc77c09c4032b75fce618bfa6d9 Cr-Commit-Position: refs/heads/master@{#403799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M cc/layers/layer_impl_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ajuma
I ran into this when working on tests for another CL (moving filters to the ...
4 years, 5 months ago (2016-07-05 15:30:15 UTC) #4
weiliangc
lgtm
4 years, 5 months ago (2016-07-05 17:12:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123793002/1
4 years, 5 months ago (2016-07-05 17:12:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 17:16:54 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 17:16:59 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 17:18:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a011ab449665cc77c09c4032b75fce618bfa6d9
Cr-Commit-Position: refs/heads/master@{#403799}

Powered by Google App Engine
This is Rietveld 408576698