remoting/BUILD.gn - Issue 2123753005: Creating new gn arg: enable_all_proguard_optimizations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/BUILD.gn

Issue 2123753005: Creating new gn arg: enable_all_proguard_optimizations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changing from 2 apks to gn arg which controls optimizations Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/BUILD.gn

diff --git a/remoting/BUILD.gn b/remoting/BUILD.gn

index 010ac717e4511c738839a62935f7d637363c2ff8..fdf4cbc7ee3caa7510657e639bafc2561f7ccacf 100644

--- a/remoting/BUILD.gn

+++ b/remoting/BUILD.gn

@@ -49,10 +49,10 @@ group("remoting_all") {

}

if (is_android) {

- deps += [

- "//remoting/android:remoting_apk",

- "//remoting/android:remoting_test_apk",

- ]

+ deps += [ "//remoting/android:remoting_apk" ]

+ if (!enable_all_proguard_optimizations) {

+ deps += [ "//remoting/android:remoting_test_apk" ]

+ }

}

if (enable_remoting_host) {

« build/config/android/rules.gni ('K') | « mojo/android/BUILD.gn ('k') | remoting/android/BUILD.gn » ('j') | no next file with comments »