blimp/client/BUILD.gn - Issue 2123753005: Creating new gn arg: enable_all_proguard_optimizations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/BUILD.gn

Issue 2123753005: Creating new gn arg: enable_all_proguard_optimizations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changing from 2 apks to gn arg which controls optimizations Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/client/BUILD.gn

diff --git a/blimp/client/BUILD.gn b/blimp/client/BUILD.gn

index 1c5725bb1b0e7bae92dee73444bc0b2e8e9d8213..61ee06c3b4d9b5caa503cc1e5928141bdae3f5e6 100644

--- a/blimp/client/BUILD.gn

+++ b/blimp/client/BUILD.gn

@@ -533,13 +533,15 @@ if (is_android) {

shared_libraries = [ ":blimp_client_android" ]

}

- instrumentation_test_apk("blimp_test_apk") {

- apk_name = "BlimpTest"

- apk_under_test = ":blimp_apk"

- android_manifest = blimp_test_apk_manifest

- android_manifest_dep = ":blimp_test_apk_manifest"

- deps = [

- ":blimp_test_java",

- ]

+ if (!enable_all_proguard_optimizations) {

+ instrumentation_test_apk("blimp_test_apk") {

+ apk_name = "BlimpTest"

+ apk_under_test = ":blimp_apk"

+ android_manifest = blimp_test_apk_manifest

+ android_manifest_dep = ":blimp_test_apk_manifest"

+ deps = [

+ ":blimp_test_java",

+ ]

+ }

}

« android_webview/tools/system_webview_shell/BUILD.gn ('K') | « blimp/BUILD.gn ('k') | build/config/android/config.gni » ('j') | build/config/android/config.gni » ('J')