Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2123743002: Rename cookie names in WebSocket cookie tests (Closed)

Created:
4 years, 5 months ago by tyoshino (SeeGerritForStatus)
Modified:
4 years, 5 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename cookie names in WebSocket cookie tests - remove unnecessary WK- prefix - Names of cookies generated by helper scripts should be independent of the user (test case) so that they can be shared among multiple test cases. We replace "pass" and "fail" with phrases that describe the attributes set to the cookies BUG=none R=yhirano Committed: https://crrev.com/667fe3c53244aed0d5c5e1f1db91fbd79227d429 Cr-Commit-Position: refs/heads/master@{#403855}

Patch Set 1 #

Patch Set 2 : a #

Patch Set 3 : a #

Patch Set 4 : Fixed cookie flooding test amount #

Messages

Total messages: 29 (15 generated)
tyoshino (SeeGerritForStatus)
4 years, 5 months ago (2016-07-05 08:12:26 UTC) #5
yhirano
http/tests/websocket/cookie-flood_wsh.py has a WK- string.
4 years, 5 months ago (2016-07-05 09:34:15 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123743002/40001
4 years, 5 months ago (2016-07-05 14:23:12 UTC) #8
tyoshino (SeeGerritForStatus)
On 2016/07/05 09:34:15, yhirano wrote: > http/tests/websocket/cookie-flood_wsh.py has a WK- string. Fixed them, too. Running ...
4 years, 5 months ago (2016-07-05 14:23:28 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/98539)
4 years, 5 months ago (2016-07-05 14:36:10 UTC) #11
yhirano
It looks net/websocket/websocket_stream_test.cc needs to be modified as well.
4 years, 5 months ago (2016-07-06 02:24:18 UTC) #12
yhirano
On 2016/07/06 02:24:18, yhirano wrote: > It looks net/websocket/websocket_stream_test.cc needs to be modified as well. ...
4 years, 5 months ago (2016-07-06 02:36:08 UTC) #13
tyoshino (SeeGerritForStatus)
On 2016/07/06 02:36:08, yhirano wrote: > On 2016/07/06 02:24:18, yhirano wrote: > > It looks ...
4 years, 5 months ago (2016-07-06 04:47:11 UTC) #14
yhirano
lgtm
4 years, 5 months ago (2016-07-06 04:58:25 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123743002/60001
4 years, 5 months ago (2016-07-06 05:13:36 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-06 06:23:59 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123743002/60001
4 years, 5 months ago (2016-07-06 06:29:48 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-06 06:34:23 UTC) #27
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 06:36:10 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/667fe3c53244aed0d5c5e1f1db91fbd79227d429
Cr-Commit-Position: refs/heads/master@{#403855}

Powered by Google App Engine
This is Rietveld 408576698