Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2123713006:
[tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory (Closed)
Description[tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory
Switch the MemoryTop10Mobile page set to use action_runner.MeasureMemory
rather than rolling its own memory dumping code snippet. Also modifies
the benchamarks:
- memory.top_10_mobile - same behavior as before
- memory.top_10_mobile_stress - run the page set in "realistic" mode
Depends on: https://codereview.chromium.org/2123713005/
BUG=625657
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/6f2b6d752f9994f123f8195f844d503cd262ec1b
Cr-Commit-Position: refs/heads/master@{#410337}
Patch Set 1 #
Total comments: 4
Patch Set 2 : rebase master #Patch Set 3 : petr's comments #
Messages
Total messages: 39 (20 generated)
Description was changed from ========== [tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory Switch the MemoryTop10Mobile page set to use action_runner.MeasureMemory rather than rolling its own memory dumping code snippet. Also modifies the benchamarks: - memory.top_10_mobile - same behavior as before - memory.top_10_mobile_stress - run the page set in "realistic" mode BUG=625657 ========== to ========== [tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory Switch the MemoryTop10Mobile page set to use action_runner.MeasureMemory rather than rolling its own memory dumping code snippet. Also modifies the benchamarks: - memory.top_10_mobile - same behavior as before - memory.top_10_mobile_stress - run the page set in "realistic" mode BUG=625657 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Description was changed from ========== [tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory Switch the MemoryTop10Mobile page set to use action_runner.MeasureMemory rather than rolling its own memory dumping code snippet. Also modifies the benchamarks: - memory.top_10_mobile - same behavior as before - memory.top_10_mobile_stress - run the page set in "realistic" mode BUG=625657 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory Switch the MemoryTop10Mobile page set to use action_runner.MeasureMemory rather than rolling its own memory dumping code snippet. Also modifies the benchamarks: - memory.top_10_mobile - same behavior as before - memory.top_10_mobile_stress - run the page set in "realistic" mode Depends on: https://codereview.chromium.org/2123713005/ BUG=625657 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
perezju@chromium.org changed reviewers: + eakuefner@chromium.org, nednguyen@google.com, petrcermak@chromium.org, primiano@chromium.org
This is the counterpart of https://codereview.chromium.org/2123713005/ I decided to start moving off just one benchmark. If all works well we can move the remaining memory benchmarks on a follow up CL.
LGTM with two comments. Thanks! Petr https://codereview.chromium.org/2123713006/diff/1/tools/perf/page_sets/memory... File tools/perf/page_sets/memory_top_10_mobile.py (right): https://codereview.chromium.org/2123713006/diff/1/tools/perf/page_sets/memory... tools/perf/page_sets/memory_top_10_mobile.py:27: self._deterministic_mode = story_set.DETERMINISTIC_MODE I don't think you need to store this at all. You should be able to access it on lines 40 and 52: action_runner.MeasureMemory(self.story_set.DETERMINISTIC_MODE) https://codereview.chromium.org/2123713006/diff/1/tools/perf/page_sets/memory... tools/perf/page_sets/memory_top_10_mobile.py:89: This means, in particular, no forced GCs nor clearing caches. nit: "NEITHER ... nor ..."
Description was changed from ========== [tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory Switch the MemoryTop10Mobile page set to use action_runner.MeasureMemory rather than rolling its own memory dumping code snippet. Also modifies the benchamarks: - memory.top_10_mobile - same behavior as before - memory.top_10_mobile_stress - run the page set in "realistic" mode Depends on: https://codereview.chromium.org/2123713005/ BUG=625657 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory Switch the MemoryTop10Mobile page set to use action_runner.MeasureMemory rather than rolling its own memory dumping code snippet. Also modifies the benchamarks: - memory.top_10_mobile - same behavior as before - memory.top_10_mobile_stress - run the page set in "realistic" mode Depends on: https://codereview.chromium.org/2123713005/ BUG=625657 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by perezju@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.perf
For more details, see http://crbug.com/617627.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
The required catapult changes have landed. Ned/Ethan, need an owner stamp. https://codereview.chromium.org/2123713006/diff/1/tools/perf/page_sets/memory... File tools/perf/page_sets/memory_top_10_mobile.py (right): https://codereview.chromium.org/2123713006/diff/1/tools/perf/page_sets/memory... tools/perf/page_sets/memory_top_10_mobile.py:27: self._deterministic_mode = story_set.DETERMINISTIC_MODE On 2016/07/07 12:52:11, petrcermak wrote: > I don't think you need to store this at all. You should be able to access it on > lines 40 and 52: > > action_runner.MeasureMemory(self.story_set.DETERMINISTIC_MODE) Done. https://codereview.chromium.org/2123713006/diff/1/tools/perf/page_sets/memory... tools/perf/page_sets/memory_top_10_mobile.py:89: This means, in particular, no forced GCs nor clearing caches. On 2016/07/07 12:52:11, petrcermak wrote: > nit: "NEITHER ... nor ..." Done.
lgtm
lgtm
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
The CQ bit was unchecked by perezju@chromium.org
The CQ bit was checked by perezju@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from petrcermak@chromium.org Link to the patchset: https://codereview.chromium.org/2123713006/#ps40001 (title: "petr's comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.perf
For more details, see http://crbug.com/617627.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) android_s5_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) mac_retina_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by perezju@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.perf
For more details, see http://crbug.com/617627.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
Description was changed from ========== [tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory Switch the MemoryTop10Mobile page set to use action_runner.MeasureMemory rather than rolling its own memory dumping code snippet. Also modifies the benchamarks: - memory.top_10_mobile - same behavior as before - memory.top_10_mobile_stress - run the page set in "realistic" mode Depends on: https://codereview.chromium.org/2123713005/ BUG=625657 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory Switch the MemoryTop10Mobile page set to use action_runner.MeasureMemory rather than rolling its own memory dumping code snippet. Also modifies the benchamarks: - memory.top_10_mobile - same behavior as before - memory.top_10_mobile_stress - run the page set in "realistic" mode Depends on: https://codereview.chromium.org/2123713005/ BUG=625657 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by perezju@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory Switch the MemoryTop10Mobile page set to use action_runner.MeasureMemory rather than rolling its own memory dumping code snippet. Also modifies the benchamarks: - memory.top_10_mobile - same behavior as before - memory.top_10_mobile_stress - run the page set in "realistic" mode Depends on: https://codereview.chromium.org/2123713005/ BUG=625657 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory Switch the MemoryTop10Mobile page set to use action_runner.MeasureMemory rather than rolling its own memory dumping code snippet. Also modifies the benchamarks: - memory.top_10_mobile - same behavior as before - memory.top_10_mobile_stress - run the page set in "realistic" mode Depends on: https://codereview.chromium.org/2123713005/ BUG=625657 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory Switch the MemoryTop10Mobile page set to use action_runner.MeasureMemory rather than rolling its own memory dumping code snippet. Also modifies the benchamarks: - memory.top_10_mobile - same behavior as before - memory.top_10_mobile_stress - run the page set in "realistic" mode Depends on: https://codereview.chromium.org/2123713005/ BUG=625657 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [tools/perf] Switch memory_top_10_mobile to action_runner.MeasureMemory Switch the MemoryTop10Mobile page set to use action_runner.MeasureMemory rather than rolling its own memory dumping code snippet. Also modifies the benchamarks: - memory.top_10_mobile - same behavior as before - memory.top_10_mobile_stress - run the page set in "realistic" mode Depends on: https://codereview.chromium.org/2123713005/ BUG=625657 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/6f2b6d752f9994f123f8195f844d503cd262ec1b Cr-Commit-Position: refs/heads/master@{#410337} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6f2b6d752f9994f123f8195f844d503cd262ec1b Cr-Commit-Position: refs/heads/master@{#410337} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
