Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2123703002: Fix worker WebSocket crash caused by dereferencing weak pointer (Closed)

Created:
4 years, 5 months ago by yhirano
Modified:
4 years, 5 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, blink-reviews, haraken, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix worker WebSocket crash caused by dereferencing weak pointer WorkerWebSocketChannel::Peer::m_bridge is bound to workerGlobalScopeDidError as |bridge|. Because it is a CrossThreadWeakPersistent, it's possible that |m_bridge| is not null when bound but |bridge| is null when called. This CL adds null pointer checks to avoid a crash. BUG=625649 Committed: https://crrev.com/bb4da95f6202839ccf81445d1d0ff2cb9c07118b Cr-Commit-Position: refs/heads/master@{#403744}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 1 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
yhirano
(context: https://codereview.chromium.org/2025783002/)
4 years, 5 months ago (2016-07-05 04:59:53 UTC) #2
nhiroki
Thank you for fixing this! LGTM
4 years, 5 months ago (2016-07-05 05:11:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123703002/20001
4 years, 5 months ago (2016-07-05 05:14:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-05 06:09:11 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 06:11:08 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb4da95f6202839ccf81445d1d0ff2cb9c07118b
Cr-Commit-Position: refs/heads/master@{#403744}

Powered by Google App Engine
This is Rietveld 408576698