Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2123683002: MD History: Address design nits (Closed)

Created:
4 years, 5 months ago by tsergeant
Modified:
4 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Address design nits This CL makes a variety of minor changes to CSS after feedback from UX design. In particular: * Adjust font weight and color of secondary text and icons * Add rounded corners to cards * Remove background color from card titles * Update item height BUG=609536 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/cc48e8d50f2028ca33b7e6a8c09b403e4fd7d032 Cr-Commit-Position: refs/heads/master@{#403847}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M chrome/browser/resources/md_history/grouped_list.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.html View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/shared_style.html View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.html View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
tsergeant
4 years, 5 months ago (2016-07-05 04:15:05 UTC) #3
calamity
lgtm
4 years, 5 months ago (2016-07-06 01:53:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123683002/1
4 years, 5 months ago (2016-07-06 03:51:50 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
4 years, 5 months ago (2016-07-06 04:02:36 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 04:05:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc48e8d50f2028ca33b7e6a8c09b403e4fd7d032
Cr-Commit-Position: refs/heads/master@{#403847}

Powered by Google App Engine
This is Rietveld 408576698