third_party/WebKit/Source/core/dom/Document.cpp - Issue 2123663003: Moved RootFrameViewport creation to happen after document attachment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2123663003: Moved RootFrameViewport creation to happen after document attachment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved RootFrameViewport creation to happen after document attachment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 0237c178a90d10d43bb4150ec865e83db8984ccb..0c3e10fb35f43f9a63b827e27d697de605581876 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -2121,6 +2121,9 @@ void Document::attach(const AttachContext& context)

m_frame->selection().documentAttached(this);

m_lifecycle.advanceTo(DocumentLifecycle::StyleClean);

+ if (FrameView* frameView = view())

+ frameView->didAttachDocument();

tdresser 2016/07/06 18:28:33 I'd be just as happy with: if (view()) view()->d

bokan 2016/07/06 18:43:52 Done.

}

void Document::detach(const AttachContext& context)

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.h » ('j') | no next file with comments »