chrome/chrome_browser.gypi - Issue 2123653006: Rename PermissionBubbleRequest to PermissionRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 2123653006: Rename PermissionBubbleRequest to PermissionRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_manager_rename

Patch Set: PermissionBubbleType -> PermissionRequestType Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_request_impl.cc ('K') | « chrome/browser/ui/website_settings/permission_bubble_view.h ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index c010005064d51122b655770430730695701237e7..2f7a8720fcce769a22e890f44f25a48ef95b05fb 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1418,8 +1418,6 @@

'browser/obsolete_system/obsolete_system_win.cc',

'browser/pdf/pdf_extension_util.cc',

'browser/pdf/pdf_extension_util.h',

- 'browser/permissions/permission_bubble_request_impl.cc',

- 'browser/permissions/permission_bubble_request_impl.h',

'browser/power/process_power_collector.cc',

'browser/power/process_power_collector.h',

'browser/process_singleton_modal_dialog_lock.cc',

@@ -2351,8 +2349,12 @@

'browser/permissions/permission_manager.h',

'browser/permissions/permission_manager_factory.cc',

'browser/permissions/permission_manager_factory.h',

+ 'browser/permissions/permission_request.cc',

+ 'browser/permissions/permission_request.h',

'browser/permissions/permission_request_id.cc',

'browser/permissions/permission_request_id.h',

+ 'browser/permissions/permission_request_impl.cc',

+ 'browser/permissions/permission_request_impl.h',

'browser/permissions/permission_request_manager.cc',

'browser/permissions/permission_request_manager.h',

'browser/permissions/permission_uma_util.cc',