chrome/browser/chrome_quota_permission_context.cc - Issue 2123653006: Rename PermissionBubbleRequest to PermissionRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_quota_permission_context.cc

Issue 2123653006: Rename PermissionBubbleRequest to PermissionRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_manager_rename

Patch Set: Fix Android Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/custom_handlers/register_protocol_handler_permission_request.h » ('j') | chrome/browser/permissions/mock_permission_request.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_quota_permission_context.cc

diff --git a/chrome/browser/chrome_quota_permission_context.cc b/chrome/browser/chrome_quota_permission_context.cc

index e5aa8bc7895d48d5087ae506da6b7d2bb0bcb8fa..0cfdb950b871f213e79e0eb0ea7bc2994e353875 100644

--- a/chrome/browser/chrome_quota_permission_context.cc

+++ b/chrome/browser/chrome_quota_permission_context.cc

@@ -12,9 +12,9 @@

#include "base/macros.h"

#include "base/strings/utf_string_conversions.h"

#include "build/build_config.h"

+#include "chrome/browser/permissions/permission_request.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/tab_contents/tab_util.h"

-#include "chrome/browser/ui/website_settings/permission_bubble_request.h"

#include "chrome/grit/generated_resources.h"

#include "chrome/grit/locale_settings.h"

#include "components/url_formatter/elide_url.h"

@@ -44,7 +44,7 @@ const int64_t kRequestLargeQuotaThreshold = 5 * 1024 * 1024;

// QuotaPermissionRequest ---------------------------------------------

-class QuotaPermissionRequest : public PermissionBubbleRequest {

+class QuotaPermissionRequest : public PermissionRequest {

public:

QuotaPermissionRequest(

ChromeQuotaPermissionContext* context,

@@ -54,7 +54,7 @@ class QuotaPermissionRequest : public PermissionBubbleRequest {

~QuotaPermissionRequest() override;

private:

- // PermissionBubbleRequest:

+ // PermissionRequest:

int GetIconId() const override;

base::string16 GetMessageTextFragment() const override;

GURL GetOrigin() const override;