Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: chrome/browser/permissions/permission_request_manager_unittest.cc

Issue 2123653006: Rename PermissionBubbleRequest to PermissionRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_manager_rename
Patch Set: Fix Android Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
11 #include "base/test/histogram_tester.h" 11 #include "base/test/histogram_tester.h"
12 #include "chrome/browser/permissions/mock_permission_request.h"
13 #include "chrome/browser/permissions/permission_request.h"
12 #include "chrome/browser/permissions/permission_request_manager.h" 14 #include "chrome/browser/permissions/permission_request_manager.h"
13 #include "chrome/browser/permissions/permission_uma_util.h" 15 #include "chrome/browser/permissions/permission_uma_util.h"
14 #include "chrome/browser/ui/website_settings/mock_permission_bubble_factory.h" 16 #include "chrome/browser/ui/website_settings/mock_permission_bubble_factory.h"
15 #include "chrome/browser/ui/website_settings/mock_permission_bubble_request.h"
16 #include "chrome/browser/ui/website_settings/permission_bubble_request.h"
17 #include "chrome/common/chrome_switches.h" 17 #include "chrome/common/chrome_switches.h"
18 #include "chrome/test/base/chrome_render_view_host_test_harness.h" 18 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
19 #include "testing/gtest/include/gtest/gtest.h" 19 #include "testing/gtest/include/gtest/gtest.h"
20 20
21 class PermissionRequestManagerTest : public ChromeRenderViewHostTestHarness { 21 class PermissionRequestManagerTest : public ChromeRenderViewHostTestHarness {
22 public: 22 public:
23 PermissionRequestManagerTest() 23 PermissionRequestManagerTest()
24 : ChromeRenderViewHostTestHarness(), 24 : ChromeRenderViewHostTestHarness(),
25 request1_("test1", PermissionBubbleType::QUOTA), 25 request1_("test1", PermissionBubbleType::QUOTA),
26 request2_("test2", PermissionBubbleType::DOWNLOAD), 26 request2_("test2", PermissionBubbleType::DOWNLOAD),
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 void MockTabSwitchAway() { manager_->HideBubble(); } 75 void MockTabSwitchAway() { manager_->HideBubble(); }
76 76
77 void MockTabSwitchBack() { manager_->DisplayPendingRequests(); } 77 void MockTabSwitchBack() { manager_->DisplayPendingRequests(); }
78 78
79 virtual void NavigationEntryCommitted( 79 virtual void NavigationEntryCommitted(
80 const content::LoadCommittedDetails& details) { 80 const content::LoadCommittedDetails& details) {
81 manager_->NavigationEntryCommitted(details); 81 manager_->NavigationEntryCommitted(details);
82 } 82 }
83 83
84 protected: 84 protected:
85 MockPermissionBubbleRequest request1_; 85 MockPermissionRequest request1_;
86 MockPermissionBubbleRequest request2_; 86 MockPermissionRequest request2_;
87 MockPermissionBubbleRequest iframe_request_same_domain_; 87 MockPermissionRequest iframe_request_same_domain_;
88 MockPermissionBubbleRequest iframe_request_other_domain_; 88 MockPermissionRequest iframe_request_other_domain_;
89 std::unique_ptr<PermissionRequestManager> manager_; 89 std::unique_ptr<PermissionRequestManager> manager_;
90 std::unique_ptr<MockPermissionBubbleFactory> view_factory_; 90 std::unique_ptr<MockPermissionBubbleFactory> view_factory_;
91 }; 91 };
92 92
93 TEST_F(PermissionRequestManagerTest, SingleRequest) { 93 TEST_F(PermissionRequestManagerTest, SingleRequest) {
94 manager_->AddRequest(&request1_); 94 manager_->AddRequest(&request1_);
95 manager_->DisplayPendingRequests(); 95 manager_->DisplayPendingRequests();
96 WaitForCoalescing(); 96 WaitForCoalescing();
97 97
98 EXPECT_TRUE(view_factory_->is_visible()); 98 EXPECT_TRUE(view_factory_->is_visible());
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 EXPECT_FALSE(request1_.finished()); 245 EXPECT_FALSE(request1_.finished());
246 246
247 WaitForCoalescing(); 247 WaitForCoalescing();
248 EXPECT_TRUE(view_factory_->is_visible()); 248 EXPECT_TRUE(view_factory_->is_visible());
249 ASSERT_EQ(view_factory_->request_count(), 1); 249 ASSERT_EQ(view_factory_->request_count(), 1);
250 } 250 }
251 251
252 TEST_F(PermissionRequestManagerTest, DuplicateRequestCancelled) { 252 TEST_F(PermissionRequestManagerTest, DuplicateRequestCancelled) {
253 manager_->DisplayPendingRequests(); 253 manager_->DisplayPendingRequests();
254 manager_->AddRequest(&request1_); 254 manager_->AddRequest(&request1_);
255 MockPermissionBubbleRequest dupe_request("test1"); 255 MockPermissionRequest dupe_request("test1");
256 manager_->AddRequest(&dupe_request); 256 manager_->AddRequest(&dupe_request);
257 EXPECT_FALSE(dupe_request.finished()); 257 EXPECT_FALSE(dupe_request.finished());
258 EXPECT_FALSE(request1_.finished()); 258 EXPECT_FALSE(request1_.finished());
259 manager_->CancelRequest(&request1_); 259 manager_->CancelRequest(&request1_);
260 EXPECT_TRUE(dupe_request.finished()); 260 EXPECT_TRUE(dupe_request.finished());
261 EXPECT_TRUE(request1_.finished()); 261 EXPECT_TRUE(request1_.finished());
262 } 262 }
263 263
264 TEST_F(PermissionRequestManagerTest, DuplicateQueuedRequest) { 264 TEST_F(PermissionRequestManagerTest, DuplicateQueuedRequest) {
265 manager_->DisplayPendingRequests(); 265 manager_->DisplayPendingRequests();
266 manager_->AddRequest(&request1_); 266 manager_->AddRequest(&request1_);
267 WaitForCoalescing(); 267 WaitForCoalescing();
268 manager_->AddRequest(&request2_); 268 manager_->AddRequest(&request2_);
269 269
270 MockPermissionBubbleRequest dupe_request("test1"); 270 MockPermissionRequest dupe_request("test1");
271 manager_->AddRequest(&dupe_request); 271 manager_->AddRequest(&dupe_request);
272 EXPECT_FALSE(dupe_request.finished()); 272 EXPECT_FALSE(dupe_request.finished());
273 EXPECT_FALSE(request1_.finished()); 273 EXPECT_FALSE(request1_.finished());
274 274
275 MockPermissionBubbleRequest dupe_request2("test2"); 275 MockPermissionRequest dupe_request2("test2");
276 manager_->AddRequest(&dupe_request2); 276 manager_->AddRequest(&dupe_request2);
277 EXPECT_FALSE(dupe_request2.finished()); 277 EXPECT_FALSE(dupe_request2.finished());
278 EXPECT_FALSE(request2_.finished()); 278 EXPECT_FALSE(request2_.finished());
279 279
280 manager_->CancelRequest(&request1_); 280 manager_->CancelRequest(&request1_);
281 EXPECT_TRUE(dupe_request.finished()); 281 EXPECT_TRUE(dupe_request.finished());
282 EXPECT_TRUE(request1_.finished()); 282 EXPECT_TRUE(request1_.finished());
283 283
284 manager_->CancelRequest(&request2_); 284 manager_->CancelRequest(&request2_);
285 EXPECT_TRUE(dupe_request2.finished()); 285 EXPECT_TRUE(dupe_request2.finished());
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 1); 597 1);
598 histograms.ExpectBucketCount( 598 histograms.ExpectBucketCount(
599 PermissionUmaUtil::kPermissionsPromptMergedBubbleDenied, 599 PermissionUmaUtil::kPermissionsPromptMergedBubbleDenied,
600 static_cast<base::HistogramBase::Sample>(PermissionBubbleType::QUOTA), 600 static_cast<base::HistogramBase::Sample>(PermissionBubbleType::QUOTA),
601 1); 601 1);
602 histograms.ExpectBucketCount( 602 histograms.ExpectBucketCount(
603 PermissionUmaUtil::kPermissionsPromptMergedBubbleDenied, 603 PermissionUmaUtil::kPermissionsPromptMergedBubbleDenied,
604 static_cast<base::HistogramBase::Sample>(PermissionBubbleType::DOWNLOAD), 604 static_cast<base::HistogramBase::Sample>(PermissionBubbleType::DOWNLOAD),
605 1); 605 1);
606 } 606 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698