Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2123653005: Activate complex text path on Android (Closed)

Created:
4 years, 5 months ago by drott
Modified:
4 years, 5 months ago
Reviewers:
eae
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Activate complex text path on Android In Chromium commit 10749067720a341 catapult was rolled, switching to default teardowns between pageset repeats, compare [1]. Activating complex text on Android again after this change in order to see how measurements are affected by this. If no memory regression shows up in the memory health measurements for memory pagesets this would indicate that we may have a memory-leakage over time problem in webview single-process mode but no issues in the usual tab process lifecycle on Android. Activating and TBR'ing to collect bot results, potentially reverting later if needed for further investigation. [1] https://github.com/catapult-project/catapult/issues/2294 BUG=577306 TBR=eae Committed: https://crrev.com/5009e3effbb04c74140d262fb71bc51cbf38913a Cr-Commit-Position: refs/heads/master@{#403884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123653005/1
4 years, 5 months ago (2016-07-06 10:23:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 11:38:03 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5009e3effbb04c74140d262fb71bc51cbf38913a Cr-Commit-Position: refs/heads/master@{#403884}
4 years, 5 months ago (2016-07-06 11:39:44 UTC) #5
eae
4 years, 5 months ago (2016-07-06 16:09:03 UTC) #6
Message was sent while issue was closed.
LGTM post-facto. Let's hope it sticks this time!

Powered by Google App Engine
This is Rietveld 408576698