Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2123653003: Remove calls to MessageLoop::current() in content. (Closed)

Created:
4 years, 5 months ago by fdoray
Modified:
4 years, 5 months ago
CC:
asanka, chromium-reviews, darin-cc_chromium.org, dcheng, devtools-reviews_chromium.org, jam, jkarlin+watch_chromium.org, michaeln, mlamouri+watch-content_chromium.org, mlamouri+watch-sensors_chromium.org, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk, nhiroki, pfeldman, riju_, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::current() in content. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. This CL is identical to https://codereview.chromium.org/2105173004/ except for a fix to content/renderer/devtools/devtools_agent.cc BUG=616447 Committed: https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67 Cr-Commit-Position: refs/heads/master@{#404207}

Patch Set 1 : identical to https://codereview.chromium.org/2105173004/ #

Patch Set 2 : change devtools_agent.cc #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : no DCHECK(CalledOnValidThread()) in constructor #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -97 lines) Patch
M content/browser/android/java/java_bridge_thread.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_request_handler_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_response_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_storage_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_url_request_job_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc View 1 2 6 chunks +11 lines, -5 lines 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory_mac.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M content/browser/download/drag_download_file.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/download/drag_download_file.cc View 9 chunks +18 lines, -20 lines 0 comments Download
M content/browser/geolocation/geolocation_provider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/geolocation_provider_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_process.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 1 2 3 2 chunks +23 lines, -8 lines 0 comments Download
M content/renderer/devtools/devtools_agent_filter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/devtools/devtools_agent_filter.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/p2p/ipc_socket_factory.cc View 15 chunks +21 lines, -21 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M device/gamepad/gamepad_provider.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
fdoray
Can you review this CL? It is identical to a CL that you already reviewed, ...
4 years, 5 months ago (2016-07-05 18:28:12 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2123653003/diff/40001/content/renderer/devtools/devtools_agent.cc File content/renderer/devtools/devtools_agent.cc (right): https://codereview.chromium.org/2123653003/diff/40001/content/renderer/devtools/devtools_agent.cc#newcode51 content/renderer/devtools/devtools_agent.cc:51: WebKitClientMessageLoopImpl() { DCHECK(CalledOnValidThread()); } how would you ever be ...
4 years, 5 months ago (2016-07-06 11:24:52 UTC) #4
fdoray
PTAnL https://codereview.chromium.org/2123653003/diff/40001/content/renderer/devtools/devtools_agent.cc File content/renderer/devtools/devtools_agent.cc (right): https://codereview.chromium.org/2123653003/diff/40001/content/renderer/devtools/devtools_agent.cc#newcode51 content/renderer/devtools/devtools_agent.cc:51: WebKitClientMessageLoopImpl() { DCHECK(CalledOnValidThread()); } On 2016/07/06 11:24:52, jochen ...
4 years, 5 months ago (2016-07-06 14:29:08 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-07 08:59:18 UTC) #6
fdoray
scottmg@chromium.org: Can you take a look at device/gamepad/gamepad_provider.cc? jochen@ already reviewed this file when it ...
4 years, 5 months ago (2016-07-07 13:52:30 UTC) #8
fdoray
bajones@: Can you review device/gamepad/gamepad_provider.cc? jochen@ already reviewed it before it was moved from content/ ...
4 years, 5 months ago (2016-07-07 13:53:46 UTC) #10
bajones
On 2016/07/07 13:53:46, fdoray wrote: > bajones@: Can you review device/gamepad/gamepad_provider.cc? jochen@ already > reviewed ...
4 years, 5 months ago (2016-07-07 15:35:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123653003/80001
4 years, 5 months ago (2016-07-07 15:42:12 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-07 19:19:15 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 19:21:45 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67
Cr-Commit-Position: refs/heads/master@{#404207}

Powered by Google App Engine
This is Rietveld 408576698