Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: remoting/client/jni/chromoting_jni_runtime.cc

Issue 21236002: Chromoting Android app mouse/keyboard bugfixes and enhancements (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One last (TODO) comment change Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/jni/chromoting_jni_instance.cc ('k') | remoting/client/jni/jni_interface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/jni/chromoting_jni_runtime.cc
diff --git a/remoting/client/jni/chromoting_jni_runtime.cc b/remoting/client/jni/chromoting_jni_runtime.cc
index a9751d44b0b7fdf508adf1cdacc9d12f1b6781f1..4913594f95a2b0fc5fb3f01432224a245a7f1da0 100644
--- a/remoting/client/jni/chromoting_jni_runtime.cc
+++ b/remoting/client/jni/chromoting_jni_runtime.cc
@@ -12,7 +12,7 @@
#include "remoting/base/url_request_context.h"
// Class and package name of the Java class supporting the methods we call.
-const char* const JAVA_CLASS = "org/chromium/chromoting/jni/JniInterface";
+const char* const kJavaClass = "org/chromium/chromoting/jni/JniInterface";
namespace remoting {
@@ -55,7 +55,7 @@ ChromotingJniRuntime::ChromotingJniRuntime() {
// Allows later decoding of video frames.
media::InitializeCPUSpecificYUVConversions();
- class_ = static_cast<jclass>(env->NewGlobalRef(env->FindClass(JAVA_CLASS)));
+ class_ = static_cast<jclass>(env->NewGlobalRef(env->FindClass(kJavaClass)));
}
ChromotingJniRuntime::~ChromotingJniRuntime() {
@@ -68,7 +68,8 @@ ChromotingJniRuntime::~ChromotingJniRuntime() {
JNIEnv* env = base::android::AttachCurrentThread();
env->DeleteGlobalRef(class_);
- // TODO(solb): crbug.com/259594 Detach all threads from JVM here.
+ // TODO(solb): Detach all threads from JVM here.
+ // crbug.com/259594
}
void ChromotingJniRuntime::ConnectToHost(const char* username,
« no previous file with comments | « remoting/client/jni/chromoting_jni_instance.cc ('k') | remoting/client/jni/jni_interface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698