Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: remoting/client/jni/android_keymap.h

Issue 21236002: Chromoting Android app mouse/keyboard bugfixes and enhancements (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One last (TODO) comment change Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/jni/android_keymap.h
diff --git a/remoting/client/jni/android_keymap.h b/remoting/client/jni/android_keymap.h
index 9a9f3a3ff271b7d97abde8b3d1090885138cec84..9368ae5a13628601356a9c031864e139feaef94d 100644
--- a/remoting/client/jni/android_keymap.h
+++ b/remoting/client/jni/android_keymap.h
@@ -10,13 +10,13 @@
namespace remoting {
-// This is a temporary hack to convert Android's virtual keycodes into USB
-// scancodes. Unfortunately, the current solution uses key mappings whose
-// layout is determined according to the client device's input locale instead
-// of the host's internationalization preferences. The whole process needs to
-// be rethought to accomplish this in an localizable and future-proof way.
-// TODO(solb): crbug.com/265945
-uint32 AndroidKeycodeToUsbKeycode(int android);
+// TODO(solb): This is a temporary hack to convert Android's virtual keycodes
+// into USB scancodes. Unfortunately, the current solution uses key mappings
+// whose layout is determined according to the client device's input locale
+// instead of the host's. The whole process needs to be rethought to accomplish
+// the mappings in a localizable and future-proof way.
+// crbug.com/265945
+uint32 AndroidKeycodeToUsbKeycode(size_t android);
} // namespace remoting
« no previous file with comments | « remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java ('k') | remoting/client/jni/android_keymap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698