Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: remoting/client/jni/android_keymap.h

Issue 21236002: Chromoting Android app mouse/keyboard bugfixes and enhancements (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix bug where pressing the numpad enter key could have closed the keyboard Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/jni/android_keymap.h
diff --git a/remoting/client/jni/android_keymap.h b/remoting/client/jni/android_keymap.h
index 9a9f3a3ff271b7d97abde8b3d1090885138cec84..0ae6312ea7e7860adea2fa944c703d7db66493d0 100644
--- a/remoting/client/jni/android_keymap.h
+++ b/remoting/client/jni/android_keymap.h
@@ -10,13 +10,14 @@
namespace remoting {
+// TODO(solb): Redesign keyboard input handling.
+// crbug.com/265945
Sergey Ulanov 2013/07/31 01:54:16 I meant that it should be formatted as follows: /
solb 2013/07/31 03:22:53 Done.
// This is a temporary hack to convert Android's virtual keycodes into USB
// scancodes. Unfortunately, the current solution uses key mappings whose
// layout is determined according to the client device's input locale instead
// of the host's internationalization preferences. The whole process needs to
// be rethought to accomplish this in an localizable and future-proof way.
-// TODO(solb): crbug.com/265945
-uint32 AndroidKeycodeToUsbKeycode(int android);
+uint32 AndroidKeycodeToUsbKeycode(size_t android);
} // namespace remoting
« no previous file with comments | « remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java ('k') | remoting/client/jni/android_keymap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698