Chromoting Android app mouse/keyboard bugfixes and enhancements

remoting/client/jni/android_keymap.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/jni/android_keymap.h"
 
+#include "base/logging.h"
+
 namespace {
 
 // These must be defined in the same order as the Android keycodes in
 // <android/keycodes.h> and
 // "ui/base/keycodes/keyboard_code_conversion_android.cc" . Some of these
 // mappings assume a US keyboard layout for now.
 const uint32 usb_keycodes[] = {
   0,         // UNKNOWN
   0,         // SOFT_LEFT
   0,         // SOFT_RIGHT
@@ skipping 177 matching lines @@
   0x070058,  // NUMPAD_ENTER
   0x070067,  // NUMPAD_EQUALS
   0x0700b6,  // NUMPAD_LEFT_PAREN
   0x0700b7,  // NUMPAD_RIGHT_PAREN
 };
 
 }
 
 namespace remoting {
 
-uint32 AndroidKeycodeToUsbKeycode(int android) {
+uint32 AndroidKeycodeToUsbKeycode(size_t android) {
+  DCHECK(android < sizeof usb_keycodes / sizeof (uint32));

[Sergey Ulanov, 2013/07/30 21:55:18]

DCHECK_LT.
Please add parenthesis around usb_keycoudes.

[solb, 2013/07/30 23:03:38]

Done.

+
   return usb_keycodes[android];
 }
 
 }  // namespace remoting