Chromoting Android app mouse/keyboard bugfixes and enhancements

remoting/android/java/src/org/chromium/chromoting/DesktopView.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.app.ActionBar;
 import android.app.Activity;
 import android.graphics.Bitmap;
 import android.graphics.Canvas;
@@ skipping 67 matching lines @@
 
     private int mMouseButton;
     private boolean mMousePressed;
 
     public DesktopView(Activity context) {
         super(context);
         mActionBar = context.getActionBar();
 
         getHolder().addCallback(this);
         DesktopListener listener = new DesktopListener();
-        mScroller = new GestureDetector(context, listener);
+        mScroller = new GestureDetector(context, listener, null, false);
         mZoomer = new ScaleGestureDetector(context, listener);
 
         mTransform = new Matrix();
         mScreenWidth = 0;
         mScreenHeight = 0;
 
         mConstraint = Constraint.UNDEFINED;
         mRecheckConstraint = false;
 
         mRightUsedToBeOut = false;
@@ skipping 73 matching lines @@
                 // Prevent the user from scrolling past the left or right edge of the image.
                 if (leftEdgeOutOfBounds != rightEdgeOutOfBounds) {
                     if (leftEdgeOutOfBounds != mRightUsedToBeOut) {
                         // Make the left edge of the image flush with the left screen edge.
                         values[Matrix.MTRANS_X] = 0;
                     }
                     else {
                         // Make the right edge of the image flush with the right screen edge.
                         values[Matrix.MTRANS_X] += mScreenWidth - bottomright[0];
                     }
-                }
-                else {
+                } else {
                     // The else prevents this from being updated during the repositioning process,
                     // in which case the view would begin to oscillate.
                     mRightUsedToBeOut = rightEdgeOutOfBounds;
                 }
 
                 // Prevent the user from scrolling past the top or bottom edge of the image.
                 if (topEdgeOutOfBounds != bottomEdgeOutOfBounds) {
                     if (topEdgeOutOfBounds != mBottomUsedToBeOut) {
                         // Make the top edge of the image flush with the top screen edge.
                         values[Matrix.MTRANS_Y] = 0;
-                    }
-                    else {
+                    } else {
                         // Make the bottom edge of the image flush with the bottom screen edge.
                         values[Matrix.MTRANS_Y] += mScreenHeight - bottomright[1];
                     }
                 }
                 else {
                     // The else prevents this from being updated during the repositioning process,
                     // in which case the view would begin to oscillate.
                     mBottomUsedToBeOut = bottomEdgeOutOfBounds;
                 }
 
@@ skipping 101 matching lines @@
                         mMouseButton = BUTTON_LEFT;
                         mMousePressed = true;
                     }
                     break;
 
                 case MotionEvent.ACTION_UP:
                     Log.i("mouse", "Lost the finger");
                     if (mMouseButton == BUTTON_UNDEFINED) {
                         // The user pressed and released without moving: do left click and release.
                         Log.i("mouse", "\tStarting and finishing left click");
-                        handleMouseMovement(coordinates, BUTTON_LEFT, true);
+                        handleMouseMovement(new float[] {coordinates[0], coordinates[1]},
+                                BUTTON_LEFT, true);
                         mMouseButton = BUTTON_LEFT;
                         mMousePressed = false;
                     }
                     else if (mMousePressed) {
                         Log.i("mouse", "\tReleasing the currently-pressed button");
                         mMousePressed = false;
                     }
                     else {
                         Log.w("mouse", "Button already in released state before gesture ended");
                     }
@@ skipping 85 matching lines @@
                 handleMouseMovement(coordinates, mMouseButton, false);
             }
 
             Log.i("mouse", "\tStarting right click");
             mMouseButton = BUTTON_RIGHT;
             mMousePressed = true;
             handleMouseMovement(coordinates, mMouseButton, mMousePressed);
         }
     }
 }