Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2123593002: Revert "Reapply zone tasks." (Closed)

Created:
4 years, 5 months ago by floitsch
Modified:
4 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Reapply zone tasks." This reverts commit f746f8f77e93fd93cb4ff3b4ed644c96a432947a. Committed: https://github.com/dart-lang/sdk/commit/dae392291595fa394d601d2d0baa77b66d85533f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -3902 lines) Patch
M sdk/lib/async/timer.dart View 3 chunks +8 lines, -139 lines 0 comments Download
M sdk/lib/async/zone.dart View 32 chunks +64 lines, -353 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 21 chunks +50 lines, -431 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 20 chunks +49 lines, -400 lines 0 comments Download
D tests/html/event_subscription_specification_test.dart View 1 chunk +0 lines, -121 lines 0 comments Download
D tests/html/event_zone_task_test.dart View 1 chunk +0 lines, -239 lines 0 comments Download
M tests/html/html.status View 2 chunks +0 lines, -2 lines 0 comments Download
D tests/html/request_animation_task_test.dart View 1 chunk +0 lines, -170 lines 0 comments Download
D tests/html/xhr_task2_test.dart View 1 chunk +0 lines, -280 lines 0 comments Download
D tests/html/xhr_task_test.dart View 1 chunk +0 lines, -508 lines 0 comments Download
D tests/lib/async/zone_task_test.dart View 1 chunk +0 lines, -310 lines 0 comments Download
D tests/lib/async/zone_timer_task_test.dart View 1 chunk +0 lines, -515 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/docs/docs.json View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 9 chunks +16 lines, -99 lines 0 comments Download
M tools/dom/src/shared_html.dart View 1 chunk +19 lines, -14 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 4 chunks +5 lines, -125 lines 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 6 chunks +8 lines, -190 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
TBR. Still failing: FAILED: dart2js-drt-checked release_ia32 html/request_animation_task_test python tools/test.py -mrelease -aia32 -cdart2js --dart2js-batch -rdrt --reset-browser-configuration ...
4 years, 5 months ago (2016-07-04 19:57:57 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as dae392291595fa394d601d2d0baa77b66d85533f (presubmit successful).
4 years, 5 months ago (2016-07-04 19:58:22 UTC) #4
floitsch
On 2016/07/04 19:58:22, floitsch wrote: > Committed patchset #1 (id:1) manually as > dae392291595fa394d601d2d0baa77b66d85533f (presubmit ...
4 years, 5 months ago (2016-07-04 20:04:33 UTC) #5
Lasse Reichstein Nielsen
4 years, 5 months ago (2016-07-05 06:17:16 UTC) #6
Message was sent while issue was closed.
Shucks! LGTM

Powered by Google App Engine
This is Rietveld 408576698