Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2123583002: Remove third_party/WebKit/LICENSE. (Closed)

Created:
4 years, 5 months ago by jbroman
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove third_party/WebKit/LICENSE. The existing file pointed to the Chromium SVN repository for AUTHORS, which is out of date. Nowadays Chromium and Blink share one git repo, so src/LICENSE and src/AUTHORS are in the same repository and apply to Blink. Pre-fork license info for WebKit was already found elsewhere (in LICENSE_FOR_ABOUT_CREDITS and in individual source files). Committed: https://crrev.com/160046bc7873ab5a61b51ce27cacde31d449f2b7 Cr-Commit-Position: refs/heads/master@{#403711}

Patch Set 1 #

Patch Set 2 : remove third_party/WebKit/LICENSE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M third_party/WebKit/LICENSE View 1 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
jbroman
Since these are now one repo, this line may not be useful anymore, but at ...
4 years, 5 months ago (2016-07-04 18:17:54 UTC) #2
Dirk Pranke
Mind just deleting the file instead?
4 years, 5 months ago (2016-07-04 18:37:29 UTC) #3
jbroman
On 2016/07/04 at 18:37:29, dpranke wrote: > Mind just deleting the file instead? Will do. ...
4 years, 5 months ago (2016-07-04 18:39:58 UTC) #4
Dirk Pranke
On 2016/07/04 18:39:58, jbroman wrote: > On 2016/07/04 at 18:37:29, dpranke wrote: > > Mind ...
4 years, 5 months ago (2016-07-04 18:52:13 UTC) #5
jbroman
On 2016/07/04 at 18:52:13, dpranke wrote: > On 2016/07/04 18:39:58, jbroman wrote: > > On ...
4 years, 5 months ago (2016-07-04 18:59:45 UTC) #7
Dirk Pranke
lgtm, thanks!
4 years, 5 months ago (2016-07-04 19:30:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123583002/20001
4 years, 5 months ago (2016-07-04 19:50:20 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-04 20:08:13 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 20:08:14 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 20:09:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/160046bc7873ab5a61b51ce27cacde31d449f2b7
Cr-Commit-Position: refs/heads/master@{#403711}

Powered by Google App Engine
This is Rietveld 408576698