Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2123573002: Convert video-[enter, mouse, scales]* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-[enter, mouse, scales]* tests to testharness.js Cleaning up video-[enter, mouse, scales]* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/e142688680130733cd15b288d01b0963256cd297 Cr-Commit-Position: refs/heads/master@{#403710}

Patch Set 1 #

Messages

Total messages: 11 (6 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-04 18:23:32 UTC) #4
fs
lgtm
4 years, 5 months ago (2016-07-04 18:30:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123573002/20001
4 years, 5 months ago (2016-07-04 18:43:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-04 19:54:15 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 19:56:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e142688680130733cd15b288d01b0963256cd297
Cr-Commit-Position: refs/heads/master@{#403710}

Powered by Google App Engine
This is Rietveld 408576698