Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2123523002: Send synthetic GestureTapDown to focus BrowserPlugin (Closed)

Created:
4 years, 5 months ago by wjmaclean
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Send synthetic GestureTapDown to focus BrowserPlugin Since we now route Gesture events directly to the guest renderer, there is no longer any event to focus the BrowserPlugin in the embedder renderer, meaning that even though touch/gesture events work properly, the guest may not receive keyboard input. This CL provides a temporary fix by sending a synthetic GestureTapDown to the embedder on TouchStarti, in parallel with sending the TouchStart directly to the guest. The synthetic event focuses the BrowserPlugin. This CL also fixes two tests that were still sending Gestures to the embedder. When BrowserPlugin is removed, this code will disappear along with RenderWidgetHostViewGuest. BUG=619906 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2101663002 Cr-Commit-Position: refs/heads/master@{#403308} (cherry picked from commit 347f2466211ae7ebbbc0a01f0f564274dc5fa3c2) Committed: https://chromium.googlesource.com/chromium/src/+/5f87571138ba5e85759984e956efcb6691cf3770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -12 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wjmaclean
4 years, 5 months ago (2016-07-04 14:40:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5f87571138ba5e85759984e956efcb6691cf3770.

Powered by Google App Engine
This is Rietveld 408576698