Issue 2123513002: Try another way to tell dartium that it's OK to fail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2123513002: Try another way to tell dartium that it's OK to fail. (Closed)

Created:
4 years, 5 months ago by Lasse Reichstein Nielsen

Modified:
4 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Try another way to tell dartium that it's OK to fail. Committed: https://github.com/dart-lang/sdk/commit/95ae8d7b971722b6454b833bfc625c9ec7bcdf87

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	tests/co19/co19-co19.status	View		1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

TBR Because the buildbot says: FAILED: none-dartium-checked release_x64 co19/Language/Functions/Formal_Parameters/syntax_t04 Expected: MissingCompileTimeError Ok Actual: Fail

4 years, 5 months ago (2016-07-04 14:27:58 UTC) #2

Lasse Reichstein Nielsen

Committed patchset #1 (id:1) manually as 95ae8d7b971722b6454b833bfc625c9ec7bcdf87 (presubmit successful).

4 years, 5 months ago (2016-07-04 14:29:07 UTC) #4

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages