Make sure the last selection gets spell checked when focusing different frame.

Source/core/editing/Editor.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 44 matching lines @@
 #include "core/editing/ReplaceSelectionCommand.h"
 #include "core/editing/SimplifyMarkupCommand.h"
 #include "core/editing/SpellChecker.h"
 #include "core/editing/TextCheckingHelper.h"
 #include "core/editing/TextIterator.h"
 #include "core/editing/TypingCommand.h"
 #include "core/editing/VisibleUnits.h"
 #include "core/editing/htmlediting.h"
 #include "core/editing/markup.h"
 #include "core/html/HTMLImageElement.h"
+#include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLTextAreaElement.h"
 #include "core/loader/cache/ResourceFetcher.h"
 #include "core/page/EditorClient.h"
 #include "core/page/EventHandler.h"
 #include "core/page/FocusController.h"
 #include "core/page/Frame.h"
 #include "core/page/FrameView.h"
 #include "core/page/Page.h"
 #include "core/page/Settings.h"
 #include "core/platform/KillRing.h"
 #include "core/platform/Pasteboard.h"
 #include "core/platform/Sound.h"
 #include "core/platform/text/TextCheckerClient.h"
 #include "core/rendering/HitTestResult.h"
 #include "core/rendering/RenderBlock.h"
 #include "core/rendering/RenderTextControl.h"
 #include "wtf/unicode/CharacterNames.h"
 
 namespace WebCore {
 
 using namespace std;
 using namespace HTMLNames;
 using namespace WTF;
 using namespace Unicode;
 
+namespace {
+
+bool isSelectionInTextField(const VisibleSelection& selection)
+{
+    HTMLTextFormControlElement* textControl = enclosingTextFormControl(selection.start());
+    return textControl && textControl->hasTagName(inputTag) && toHTMLInputElement(textControl)->isTextField();
+}
+
+} // namespace
+
 // When an event handler has moved the selection outside of a text control
 // we should use the target control's selection for this editing operation.
 VisibleSelection Editor::selectionForCommand(Event* event)
 {
     VisibleSelection selection = m_frame->selection()->selection();
     if (!event)
         return selection;
     // If the target is a text control, and the current selection is outside of its shadow tree,
     // then use the saved selection for that text control.
     HTMLTextFormControlElement* textFormControlOfSelectionStart = enclosingTextFormControl(selection.start());
@@ skipping 2178 matching lines @@
     if (!isContinuousSpellCheckingEnabled)
         m_frame->document()->markers()->removeMarkers(DocumentMarker::Spelling);
     if (!isContinuousGrammarCheckingEnabled)
         m_frame->document()->markers()->removeMarkers(DocumentMarker::Grammar);
 
     cancelCompositionIfSelectionIsInvalid();
 
     notifyComponentsOnChangedSelection(oldSelection, options);
 }
 
+void Editor::respondToChangedFocusedOrActiveState(bool activeAndFocused)
+{
+    if (!activeAndFocused) {

[tony, 2013/08/02 20:35:03]

Nit: It's a little easier to read if you early return if (activeAndFocused). One
less level of indent.

+        if (!m_frame->selection()->selection().isContentEditable())
+            return;
+
+        if (isSelectionInTextField(m_frame->selection()->selection())) {
+            // textFieldDidEndEditing() and textFieldDidBeginEditing() handle this.
+            return;
+        }
+
+        // Make sure a current selection gets spell checked when unfocusing an editable element
+        // by activating different frame.

[tony, 2013/08/02 20:35:03]

This is a 'what' comment, which we normally avoid in blink code.  Instead, you
could make a helper function like, 'spellCheckDuringBlur' or something.  I would
probably just rename Editor::respondToChangedFocusedOrActiveState to
Editor::spellCheckAfterBlur and do the !activeAndFocused in FrameSelection.

+        VisiblePosition start(m_frame->selection()->selection().visibleStart());

[tony, 2013/08/02 20:35:03]

This code seems similar to the code in respondToChangedSelection.  Is it
possible to share some code between the two?

+        VisibleSelection adjacentWords = VisibleSelection(startOfWord(start, LeftWordIfOnBoundary), endOfWord(start, RightWordIfOnBoundary));
+        if (isContinuousSpellCheckingEnabled() && isGrammarCheckingEnabled()) {
+            VisibleSelection selectedSentence = VisibleSelection(startOfSentence(start), endOfSentence(start));
+            markMisspellingsAndBadGrammar(adjacentWords, true, selectedSentence);

[tony, 2013/08/02 20:35:03]

A good cleanup change would be converting the bool into an enum.

[pstanek, 2013/08/04 00:00:06]

Sure but note I'm not doing this within this bug fix.

+        } else {
+            markMisspellingsAndBadGrammar(adjacentWords, false, adjacentWords);
+        }
+    }
+}
+
 static Node* findFirstMarkable(Node* node)
 {
     while (node) {
         if (!node->renderer())
             return 0;
         if (node->renderer()->isText())
             return node;
         if (node->renderer()->isTextControl())
             node = toRenderTextControl(node->renderer())->textFormControlElement()->visiblePositionForIndex(1).deepEquivalent().deprecatedNode();
         else if (node->firstChild())
@@ skipping 42 matching lines @@
     return WebCore::unifiedTextCheckerEnabled(m_frame);
 }
 
 void Editor::toggleOverwriteModeEnabled()
 {
     m_overwriteModeEnabled = !m_overwriteModeEnabled;
     frame()->selection()->setShouldShowBlockCursor(m_overwriteModeEnabled);
 };
 
 } // namespace WebCore