Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Issue 2123483002: Revert of [Autofill] Add typemap for PasswordForm and PasswordFormGenerationData. (Closed)

Created:
4 years, 5 months ago by Finnur
Modified:
4 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, yzshen+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, Aaron Boodman, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, darin (slow to review), abarth-chromium, ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Autofill] Add typemap for PasswordForm and PasswordFormGenerationData. (patchset #9 id:160001 of https://codereview.chromium.org/2101533002/ ) Reason for revert: Caused compile failure: https://build.chromium.org/p/chromium/buildstatus?builder=Mac&number=17333 Original issue's description: > [Autofill] Add typemap for PasswordForm and PasswordFormGenerationData. > > This CL is basis to mojofy IPCs between: > ContentPasswordManagerDriver<-->PasswordAutofillAgent > ContentPasswordManagerDriver<-->PasswordGenerationAgent > > TEST=components_unittests --gtest_filter=AutofillTypeTraitsTestImpl* > BUG=582391 > > Committed: https://crrev.com/4638cbe08ea8775a448e0537545f2f7e5f9ad336 > Cr-Commit-Position: refs/heads/master@{#403658} TBR=vabr@chromium.org,mathp@chromium.org,yzshen@chromium.org,dcheng@chromium.org,leon.han@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=582391 Committed: https://crrev.com/a5544691391a62c14de200aee784971ead079af6 Cr-Commit-Position: refs/heads/master@{#403662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -651 lines) Patch
M components/autofill.gypi View 3 chunks +0 lines, -5 lines 0 comments Download
M components/autofill/content/public/cpp/autofill_types.typemap View 2 chunks +0 lines, -8 lines 0 comments Download
M components/autofill/content/public/cpp/autofill_types_struct_traits.h View 3 chunks +0 lines, -211 lines 0 comments Download
M components/autofill/content/public/cpp/autofill_types_struct_traits.cc View 8 chunks +0 lines, -243 lines 0 comments Download
M components/autofill/content/public/cpp/autofill_types_struct_traits_unittest.cc View 5 chunks +0 lines, -104 lines 0 comments Download
M components/autofill/content/public/interfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/content/public/interfaces/autofill_types.mojom View 3 chunks +0 lines, -75 lines 0 comments Download
M components/autofill/content/public/interfaces/test_autofill_types.mojom View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Finnur
Created Revert of [Autofill] Add typemap for PasswordForm and PasswordFormGenerationData.
4 years, 5 months ago (2016-07-04 11:09:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123483002/1
4 years, 5 months ago (2016-07-04 11:09:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 11:10:24 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 11:10:30 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 11:12:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5544691391a62c14de200aee784971ead079af6
Cr-Commit-Position: refs/heads/master@{#403662}

Powered by Google App Engine
This is Rietveld 408576698