Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2123423003: Convert editing/inserting/insert-div-018.html to use w3c test harness (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/inserting/insert-div-018.html to use w3c test harness This patch converts "editing/inserting/insert-div-018.html" to use w3c test harness to avoid pixel comparison since this test doesn't need to check pixels for simplify test case. crrev.com/2124213002 Make EphemeralRange constructor not to accept invalid start and end positions. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/cf232d40c5eba8f30c069b6774c3c68d4caa2b0c Cr-Commit-Position: refs/heads/master@{#404103}

Patch Set 1 : 2016-07-07T16:02:59 #

Messages

Total messages: 10 (4 generated)
yosin_UTC9
PTAL BTW, we have 'insert-div-0%02d.html' % (1 .. 28) :-<
4 years, 5 months ago (2016-07-07 07:10:29 UTC) #3
yoichio
lgtm
4 years, 5 months ago (2016-07-07 08:38:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123423003/1
4 years, 5 months ago (2016-07-07 08:54:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 09:15:29 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 09:15:34 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 09:17:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf232d40c5eba8f30c069b6774c3c68d4caa2b0c
Cr-Commit-Position: refs/heads/master@{#404103}

Powered by Google App Engine
This is Rietveld 408576698