Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2123343002: Break xfa_basic_data up to smaller files (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Break xfa_basic_data up to smaller files xfa_basic_data is a large (>7k lines) file that is difficult to navigate. This CL breaks the file up into smaller files more logical files. Committed: https://pdfium.googlesource.com/pdfium/+/8bdbc88f3416eb074cfc4a609252aa53ef8a7ec3

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2810 lines, -9815 lines) Patch
M BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M xfa.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_data.cpp View 2 chunks +1 line, -6394 lines 0 comments Download
A xfa/fxfa/parser/xfa_basic_data_attributes.cpp View 1 1 chunk +785 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/xfa_basic_data_element_attributes.cpp View 1 1 chunk +1188 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/xfa_basic_data_element_properties.cpp View 1 1 chunk +487 lines, -0 lines 0 comments Download
A + xfa/fxfa/parser/xfa_basic_data_element_script.cpp View 1 3 chunks +2 lines, -3421 lines 0 comments Download
A xfa/fxfa/parser/xfa_basic_data_enum.cpp View 1 1 chunk +281 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/xfa_basic_data_packets.cpp View 1 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL. I broke the file along conceptual lines, make sense?
4 years, 5 months ago (2016-07-06 19:53:24 UTC) #2
Wei Li
lgtm https://codereview.chromium.org/2123343002/diff/1/xfa/fxfa/parser/xfa_basic_data_attributes.cpp File xfa/fxfa/parser/xfa_basic_data_attributes.cpp (right): https://codereview.chromium.org/2123343002/diff/1/xfa/fxfa/parser/xfa_basic_data_attributes.cpp#newcode1 xfa/fxfa/parser/xfa_basic_data_attributes.cpp:1: // Copyright 2014 PDFium Authors. All rights reserved. ...
4 years, 5 months ago (2016-07-06 22:43:00 UTC) #3
dsinclair
4 years, 5 months ago (2016-07-07 13:40:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123343002/20001
4 years, 5 months ago (2016-07-07 13:40:49 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 14:55:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8bdbc88f3416eb074cfc4a609252aa53ef8a...

Powered by Google App Engine
This is Rietveld 408576698