Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2123333003: Remove base::mac::LibDispatchTaskRunner and migrate its sole client to plain libdispatch. (Closed)

Created:
4 years, 5 months ago by Robert Sesek
Modified:
4 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::mac::LibDispatchTaskRunner and migrate its sole client to plain libdispatch. BUG=598836 R=mark@chromium.org Committed: https://crrev.com/74c8f3daf5bdd8114687119a1061b1ae6c69b8ab Cr-Commit-Position: refs/heads/master@{#404190}

Patch Set 1 #

Patch Set 2 : Tweak comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -437 lines) Patch
M base/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M base/files/file_path_watcher_fsevents.h View 2 chunks +7 lines, -3 lines 0 comments Download
M base/files/file_path_watcher_fsevents.cc View 1 13 chunks +27 lines, -36 lines 1 comment Download
D base/mac/libdispatch_task_runner.h View 1 chunk +0 lines, -80 lines 0 comments Download
D base/mac/libdispatch_task_runner.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D base/mac/libdispatch_task_runner_unittest.cc View 1 chunk +0 lines, -229 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Robert Sesek
https://codereview.chromium.org/2123333003/diff/20001/base/files/file_path_watcher_fsevents.cc File base/files/file_path_watcher_fsevents.cc (left): https://codereview.chromium.org/2123333003/diff/20001/base/files/file_path_watcher_fsevents.cc#oldcode168 base/files/file_path_watcher_fsevents.cc:168: DCHECK(g_task_runner.Get().RunsTasksOnCurrentThread()); We lose these DCHECKs, but as noted in ...
4 years, 5 months ago (2016-07-07 14:55:17 UTC) #1
Mark Mentovai
LGTM
4 years, 5 months ago (2016-07-07 18:02:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123333003/20001
4 years, 5 months ago (2016-07-07 18:20:02 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 18:43:45 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 18:47:09 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/74c8f3daf5bdd8114687119a1061b1ae6c69b8ab
Cr-Commit-Position: refs/heads/master@{#404190}

Powered by Google App Engine
This is Rietveld 408576698