Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2123333002: Issue 26821. Don't add 'void' return type for setters when lint 'avoid_return_types_on_setters' is … (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 26821. Don't add 'void' return type for setters when lint 'avoid_return_types_on_setters' is enabled. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/26821 Committed: https://github.com/dart-lang/sdk/commit/dc425004085a4bd4706528a593649f02c37bd921

Patch Set 1 #

Patch Set 2 : Never generate 'void' return type for setters. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 5 months ago (2016-07-06 19:40:49 UTC) #1
Brian Wilkerson
lgtm, but even 'always_declare_return_types' doesn't require a return type on a setter, so perhaps we ...
4 years, 5 months ago (2016-07-06 19:51:10 UTC) #2
scheglov
On 2016/07/06 19:51:10, Brian Wilkerson wrote: > lgtm, but even 'always_declare_return_types' doesn't require a return ...
4 years, 5 months ago (2016-07-06 20:00:17 UTC) #3
scheglov
4 years, 5 months ago (2016-07-06 20:00:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dc425004085a4bd4706528a593649f02c37bd921 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698