content/common/origin_trials/trial_token_validator.h - Issue 2123323004: Simplify OriginTrialContext and the way it validates tokens.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/origin_trials/trial_token_validator.h

Issue 2123323004: Simplify OriginTrialContext and the way it validates tokens. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mark enum as obsolete Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/origin_trials/trial_token_validator.h

diff --git a/content/common/origin_trials/trial_token_validator.h b/content/common/origin_trials/trial_token_validator.h

index 07f99c745ff7db1c8464472f3eec039278e4f19d..ec74e9ac5ae26c3433eef76b2040e17681cb5a6e 100644

--- a/content/common/origin_trials/trial_token_validator.h

+++ b/content/common/origin_trials/trial_token_validator.h

@@ -18,11 +18,13 @@ namespace content {

namespace TrialTokenValidator {

+// If token validates, |*feature_name| is set to the name of the feature the

+// token enables.

// This method is thread-safe.

CONTENT_EXPORT blink::WebOriginTrialTokenStatus ValidateToken(

const std::string& token,

const url::Origin& origin,

- base::StringPiece feature_name);

+ std::string* feature_name);

} // namespace TrialTokenValidator

« no previous file with comments | « content/common/origin_trials/trial_token_unittest.cc ('k') | content/common/origin_trials/trial_token_validator.cc » ('j') | no next file with comments »