third_party/WebKit/public/platform/WebTrialTokenValidator.h - Issue 2123323004: Simplify OriginTrialContext and the way it validates tokens.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebTrialTokenValidator.h

Issue 2123323004: Simplify OriginTrialContext and the way it validates tokens. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: actually skip empty tokens in addTokens Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/platform/WebOriginTrialTokenStatus.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/WebTrialTokenValidator.h

diff --git a/third_party/WebKit/public/platform/WebTrialTokenValidator.h b/third_party/WebKit/public/platform/WebTrialTokenValidator.h

index 9b7860c4ea5877e309d32c42fed988aa936c8506..8666cbedd3f3b9d5776e40e7ae3c9594d6245a1a 100644

--- a/third_party/WebKit/public/platform/WebTrialTokenValidator.h

+++ b/third_party/WebKit/public/platform/WebTrialTokenValidator.h

@@ -24,9 +24,10 @@ class WebTrialTokenValidator {

public:

virtual ~WebTrialTokenValidator() {}

- // Returns true if the given token is valid for the specified origin and

- // feature name.

- virtual WebOriginTrialTokenStatus validateToken(const WebString& token, const WebSecurityOrigin&, const WebString& featureName) = 0;

+ // Returns whether the given token is valid for the specified origin. If the

+ // token is valid, it also returns the feature the token is valid for in

+ // |*featureName|.

+ virtual WebOriginTrialTokenStatus validateToken(const WebString& token, const WebSecurityOrigin&, WebString* featureName) = 0;

};

} // namespace blink