Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2123323004: Simplify OriginTrialContext and the way it validates tokens. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: filter empty tokens in addTokens, and DCHECK in validateToken Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index d598f02f15e8582afac6462b569e41e43890def6..1ffc767f5c783ac07058a28bbcb7df8700b25410 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -36993,6 +36993,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="OriginTrials.FeatureEnabled" enum="OriginTrialEnableResult">
+ <obsolete>
+ Obsolete as of Chrome 54. Sort of replaced by OriginTrials.ValidationResult.
+ </obsolete>
<owner>chasej@chromium.org</owner>
<owner>iclelland@chromium.org</owner>
<summary>
@@ -37004,6 +37007,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="OriginTrials.FeatureEnabled.MessageGenerated"
enum="OriginTrialMessageGeneratedResult">
+ <obsolete>
+ Obsolete as of Chrome 54.
+ </obsolete>
<owner>chasej@chromium.org</owner>
<owner>iclelland@chromium.org</owner>
<summary>
@@ -37012,6 +37018,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="OriginTrials.ValidationResult" enum="OriginTrialTokenStatus">
+ <owner>chasej@chromium.org</owner>
+ <owner>iclelland@chromium.org</owner>
+ <summary>
+ Counts the results of token validation checks to enable experimental
+ features. The result for each token validation check is counted once per
+ token per execution context (e.g. page, worker).
+ </summary>
+</histogram>
+
<histogram name="OSX.BluetoothAvailability" enum="BluetoothAvailability">
<owner>erikchen@chromium.org</owner>
<summary>
@@ -85060,6 +85076,9 @@ To add a new entry, add it with any value and run test to compute valid value.
</enum>
<enum name="OriginTrialEnableResult" type="int">
+ <obsolete>
+ Obsolete as of M54 and replaced by OriginTrialTokenStatus.
+ </obsolete>
<int value="0" label="Success"/>
<int value="1" label="NotSupported"/>
<int value="2" label="Insecure"/>
@@ -85079,6 +85098,18 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="2" label="No"/>
</enum>
+<enum name="OriginTrialTokenStatus" type="int">
+ <int value="0" label="Success"/>
+ <int value="1" label="NotSupported"/>
+ <int value="2" label="Insecure"/>
+ <int value="3" label="Expired"/>
+ <int value="4" label="WrongOrigin"/>
+ <int value="5" label="InvalidSignature"/>
+ <int value="6" label="Malformed"/>
+ <int value="7" label="WrongVersion"/>
+ <int value="8" label="FeatureDisabled"/>
+</enum>
+
<enum name="OSAgnosticErrno" type="int">
<summary>Errno values with the same meanings on Mac/Win/Linux.</summary>
<int value="0" label="0">No error</int>

Powered by Google App Engine
This is Rietveld 408576698