[turbofan] Renamed tracing flags for TurboFan reducers and graph trimmer

[turbofan] Renamed tracing flags for TurboFan reducers and graph trimmer

Added trace printout for replacements in Turbofan reducers.
Renamed graph trimmer trace flag to avoid confusion.

Committed: https://crrev.com/64ff8f8daa52331d60416ec551c16f783f6c56a2
Cr-Commit-Position: refs/heads/master@{#37663}

[Deon, 2016-07-07 21:18:24]

diaoyuanjie@gmail.com changed reviewers:
+ bmeurer@chromium.org

[Deon, 2016-07-07 21:18:25]

This is follow-up from https://codereview.chromium.org/1992653003/. Sorry that I
could not figure out how to reuse the old issue#.

[Benedikt Meurer, 2016-07-09 17:41:24]

Description was changed from

==========
Renamed tracing flags for TurboFan reducers and graph trimmer

Added trace printout for replacements in Turbofan reducers.
Renamed graph trimmer trace flag to avoid confusion.

BUG=
==========

to

==========
[turbofan] Renamed tracing flags for TurboFan reducers and graph trimmer

Added trace printout for replacements in Turbofan reducers.
Renamed graph trimmer trace flag to avoid confusion.
==========

[Benedikt Meurer, 2016-07-09 17:45:23]

Thanks for the new CL. Almost landable, just two minor comments. :-)

https://codereview.chromium.org/2123283006/diff/1/src/compiler/graph-reducer.cc
File src/compiler/graph-reducer.cc (right):

https://codereview.chromium.org/2123283006/diff/1/src/compiler/graph-reducer....
src/compiler/graph-reducer.cc:171: if (FLAG_trace_turbo_reduction) {
Can you use the streams instead? I.e. sth along the lines of

OFStream os(stdout);
os << "- Replacing " << *node << " with " *replacement << std::endl;

https://codereview.chromium.org/2123283006/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2123283006/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:444: DEFINE_BOOL(trace_turbo_trimmer, false, "trace
TurboFan's graph trimmer")
Please rename to trace_turbo_trimming.

[Benedikt Meurer, 2016-07-09 17:46:30]

Ah, and BTW. did you sign the contributor agreement already
(https://github.com/v8/v8/wiki/Contributing#the-small-print)?

[Deon, 2016-07-11 21:39:16]

Thanks for the suggestions! I have made all the changes. PTAL :)

[Deon, 2016-07-11 21:39:46]

The CQ bit was checked by diaoyuanjie@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 21:39:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 21:39:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 21:39:52]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[Deon, 2016-07-11 21:40:06]

The CQ bit was unchecked by diaoyuanjie@gmail.com

[Benedikt Meurer, 2016-07-12 03:22:47]

Thanks. LGTM.

[Benedikt Meurer, 2016-07-12 03:23:03]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-07-12 03:23:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 03:55:01]

Description was changed from

==========
[turbofan] Renamed tracing flags for TurboFan reducers and graph trimmer

Added trace printout for replacements in Turbofan reducers.
Renamed graph trimmer trace flag to avoid confusion.
==========

to

==========
[turbofan] Renamed tracing flags for TurboFan reducers and graph trimmer

Added trace printout for replacements in Turbofan reducers.
Renamed graph trimmer trace flag to avoid confusion.
==========

[commit-bot: I haz the power, 2016-07-12 03:55:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-12 03:56:16]

Description was changed from

==========
[turbofan] Renamed tracing flags for TurboFan reducers and graph trimmer

Added trace printout for replacements in Turbofan reducers.
Renamed graph trimmer trace flag to avoid confusion.
==========

to

==========
[turbofan] Renamed tracing flags for TurboFan reducers and graph trimmer

Added trace printout for replacements in Turbofan reducers.
Renamed graph trimmer trace flag to avoid confusion.

Committed: https://crrev.com/64ff8f8daa52331d60416ec551c16f783f6c56a2
Cr-Commit-Position: refs/heads/master@{#37663}
==========

[commit-bot: I haz the power, 2016-07-12 03:56:17]

Patchset 2 (id:??) landed as
https://crrev.com/64ff8f8daa52331d60416ec551c16f783f6c56a2
Cr-Commit-Position: refs/heads/master@{#37663}