Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2123283005: Added '.m' pattern to git cl format files to be covered. (Closed)

Created:
4 years, 5 months ago by Anna Zeng
Modified:
4 years, 5 months ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added '.m' pattern to git cl format files to be covered. BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/bf47014c1a87c15629c9cd6fd9b94b669d498a00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M git_cl.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Anna Zeng
Hi friends! I realized that git cl format was not touching any of my .m ...
4 years, 5 months ago (2016-07-07 19:28:55 UTC) #3
tandrii(chromium)
what's .m files? LGTM though.
4 years, 5 months ago (2016-07-07 19:34:07 UTC) #5
tandrii(chromium)
FTR, i did find m files https://cs.chromium.org/search/?q=%5E*%5C.m$&sq=package:chromium&type=cs, but I still haven't figured out what they ...
4 years, 5 months ago (2016-07-07 19:36:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123283005/1
4 years, 5 months ago (2016-07-07 23:38:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123283005/1
4 years, 5 months ago (2016-07-07 23:39:15 UTC) #11
Mark Mentovai
We wouldn’t ever format anything in third_party this way though. I checked and I didn’t ...
4 years, 5 months ago (2016-07-07 23:40:00 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 23:43:04 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/bf47014c1a87c1...

Powered by Google App Engine
This is Rietveld 408576698