Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2123243002: [mb] Fix shared-library bots. (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, tandrii(chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mb] Fix shared-library bots. Because the release_bot mixin includes the 'static' config, the shared-library bots included both 'static' and 'shared'. This removes the wrong 'static' config. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org Committed: https://crrev.com/00c51b99edf4657a0f5bd6060b9666cf4ca1e868 Cr-Commit-Position: refs/heads/master@{#37556}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M infra/mb/mb_config.pyl View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123243002/1
4 years, 5 months ago (2016-07-06 14:26:38 UTC) #4
Michael Achenbach
TBR - I was afraid that bugs like that would happen. Well, now I detected ...
4 years, 5 months ago (2016-07-06 14:28:34 UTC) #5
Michael Achenbach
https://codereview.chromium.org/2123243002/diff/1/infra/mb/mb_config.pyl File infra/mb/mb_config.pyl (right): https://codereview.chromium.org/2123243002/diff/1/infra/mb/mb_config.pyl#newcode476 infra/mb/mb_config.pyl:476: 'mixins': ['release', 'static', 'goma'], The 'static' here is the ...
4 years, 5 months ago (2016-07-06 14:29:46 UTC) #6
tandrii(chromium)
lgtm
4 years, 5 months ago (2016-07-06 14:32:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123243002/1
4 years, 5 months ago (2016-07-06 14:34:08 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 15:07:02 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 15:07:03 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 15:07:45 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00c51b99edf4657a0f5bd6060b9666cf4ca1e868
Cr-Commit-Position: refs/heads/master@{#37556}

Powered by Google App Engine
This is Rietveld 408576698