Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by Michael Achenbach Modified:
4 years, 5 months ago Reviewers:
jochen (gone - plz use gerrit), vogelheim, tandrii(chromium) CC:
v8-reviews_googlegroups.com, tandrii(chromium) Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[mb] Fix shared-library bots.
Because the release_bot mixin includes the 'static' config,
the shared-library bots included both 'static' and 'shared'.
This removes the wrong 'static' config.
BUG=chromium:474921
TBR=vogelheim@chromium.org, jochen@chromium.org
Committed: https://crrev.com/00c51b99edf4657a0f5bd6060b9666cf4ca1e868
Cr-Commit-Position: refs/heads/master@{#37556}
Patch Set 1 #
Total comments: 1
Created: 4 years, 5 months ago
Messages
Total messages: 16 (8 generated)
Description was changed from ========== [mb] Fix shared-library bots. BUG= ========== to ========== [mb] Fix shared-library bots. Because the release_bot mixin includes the 'static' config, the shared-library bots included both 'static' and 'shared'. This removes the wrong 'static' config. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org, vogelheim@chromium.org
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
TBR - I was afraid that bugs like that would happen. Well, now I detected this one. My infra-side diff tool didn't take duplicate keys into account apparently. All gyp flags on the infra side are in a dict and the latter 'component' key overwrote the former. But in mb, you can use the same key twice.
https://codereview.chromium.org/2123243002/diff/1/infra/mb/mb_config.pyl File infra/mb/mb_config.pyl (right): https://codereview.chromium.org/2123243002/diff/1/infra/mb/mb_config.pyl#newc... infra/mb/mb_config.pyl:476: 'mixins': ['release', 'static', 'goma'], The 'static' here is the problem when using 'release_bot' together with 'shared'.
tandrii@chromium.org changed reviewers: + tandrii@chromium.org
lgtm
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [mb] Fix shared-library bots. Because the release_bot mixin includes the 'static' config, the shared-library bots included both 'static' and 'shared'. This removes the wrong 'static' config. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org ========== to ========== [mb] Fix shared-library bots. Because the release_bot mixin includes the 'static' config, the shared-library bots included both 'static' and 'shared'. This removes the wrong 'static' config. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== [mb] Fix shared-library bots. Because the release_bot mixin includes the 'static' config, the shared-library bots included both 'static' and 'shared'. This removes the wrong 'static' config. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org ========== to ========== [mb] Fix shared-library bots. Because the release_bot mixin includes the 'static' config, the shared-library bots included both 'static' and 'shared'. This removes the wrong 'static' config. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org Committed: https://crrev.com/00c51b99edf4657a0f5bd6060b9666cf4ca1e868 Cr-Commit-Position: refs/heads/master@{#37556} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/00c51b99edf4657a0f5bd6060b9666cf4ca1e868 Cr-Commit-Position: refs/heads/master@{#37556} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
