Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212323003: Remove the mediaFullscreenRequiresUserGesture setting (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, sof, philipj_slow, eae+blinkwatch, eric.carlson_apple.com, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, Inactive
Visibility:
Public.

Description

Remove the mediaFullscreenRequiresUserGesture setting It is no longer set by Chromium and is always true. BUG=355439 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170416

Patch Set 1 #

Patch Set 2 : drop include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -25 lines) Patch
M LayoutTests/media/video-enter-fullscreen-without-user-gesture.html View 2 chunks +3 lines, -11 lines 0 comments Download
M LayoutTests/media/video-enter-fullscreen-without-user-gesture-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 1 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/frame/Settings.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebSettings.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
philipj_slow
Patch 3/3, depends on https://codereview.chromium.org/212133003/
6 years, 9 months ago (2014-03-26 07:47:37 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 9 months ago (2014-03-26 17:48:14 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-29 06:38:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/212323003/1
6 years, 9 months ago (2014-03-29 06:38:07 UTC) #4
philipj_slow
The CQ bit was unchecked by philipj@opera.com
6 years, 9 months ago (2014-03-29 06:38:53 UTC) #5
philipj_slow
abarth, can you review WebSettings?
6 years, 9 months ago (2014-03-29 07:39:22 UTC) #6
eseidel
lgtm
6 years, 8 months ago (2014-03-29 16:58:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/212323003/50001
6 years, 8 months ago (2014-03-29 16:58:14 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 17:09:45 UTC) #9
Message was sent while issue was closed. 
Change committed as 170416

Powered by Google App Engine
This is Rietveld 408576698