Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 2123223002: [swarming] Port updated version of isolate_driver.py (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, M-A Ruel
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[swarming] Port updated version of isolate_driver.py This version of the isolate_driver includes a feature that automatically derives shared libraries for inclusion. This is needed for GN as the shared library location is different compared to gyp and having different configs would be tedious. This also removes the shared-library-specific configs as they are no longer needed with the new driver. BUG=chromium:474921 Committed: https://crrev.com/77fbb1c3512f17eefb8a2765b122bc517ed05c79 Cr-Commit-Position: refs/heads/master@{#37555}

Patch Set 1 : 1:1 copy of chromium's isolate_driver.py #

Total comments: 1

Patch Set 2 : Port https://codereview.chromium.org/2039873002 #

Patch Set 3 : Remove component-build-specific configs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -25 lines) Patch
M src/base.isolate View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M tools/isolate_driver.py View 1 5 chunks +266 lines, -9 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123223002/1
4 years, 5 months ago (2016-07-06 13:07:41 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/4480) v8_linux64_rel_ng on ...
4 years, 5 months ago (2016-07-06 13:09:54 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123223002/20001
4 years, 5 months ago (2016-07-06 13:19:03 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-06 13:41:52 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123223002/40001
4 years, 5 months ago (2016-07-06 13:55:50 UTC) #11
Michael Achenbach
PTAL. This is to unblock switching our shared-library bots to GN. On the long-term it ...
4 years, 5 months ago (2016-07-06 14:12:40 UTC) #14
tandrii(chromium)
lgtm
4 years, 5 months ago (2016-07-06 14:16:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123223002/40001
4 years, 5 months ago (2016-07-06 14:18:33 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-06 14:20:34 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 14:21:20 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/77fbb1c3512f17eefb8a2765b122bc517ed05c79
Cr-Commit-Position: refs/heads/master@{#37555}

Powered by Google App Engine
This is Rietveld 408576698