Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2123193002: Add GlyphMetricsMap memory consumption to memory-infra tracing (Closed)

Created:
4 years, 5 months ago by drott
Modified:
4 years, 4 months ago
Reviewers:
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Not for Review] Add GlyphMetricsMap memory consumption to memory-infra tracing Visiting Wikipedia and clicking through a set of pages on the same domain, the glyphtoboundsmaps_total_size value climbs quickly to 1.2MB. This indicates removing the m_glyphsToBoundsMap might be a useful area for saving memory. BUG=589462 R=haraken,eae,tzik,kojii

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/fonts/FontCache.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCacheMemoryDumpProvider.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDataCache.h View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDataCache.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/GlyphMetricsMap.h View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/SimpleFontData.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
drott
4 years, 5 months ago (2016-07-06 11:38:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123193002/1
4 years, 5 months ago (2016-07-06 11:38:51 UTC) #3
drott
Let's hold the review on this, I might remove the glyphtobounds map altogether.
4 years, 5 months ago (2016-07-06 11:52:54 UTC) #7
kojii
On 2016/07/06 at 11:52:54, drott wrote: > Let's hold the review on this, I might ...
4 years, 5 months ago (2016-07-06 12:52:10 UTC) #8
drott
On 2016/07/06 at 12:52:10, kojii wrote: > On 2016/07/06 at 11:52:54, drott wrote: > > ...
4 years, 5 months ago (2016-07-06 13:23:44 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-06 13:37:39 UTC) #11
eae
On 2016/07/06 11:52:54, drott wrote: > Let's hold the review on this, I might remove ...
4 years, 5 months ago (2016-07-06 16:10:18 UTC) #12
drott
4 years, 4 months ago (2016-08-11 18:16:22 UTC) #13
Message was sent while issue was closed.
Glyph metrics caches removed.

Powered by Google App Engine
This is Rietveld 408576698