Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2123163002: Roll buildtools d2664782a3..067577af4b (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools d2664782a3..067577af4b In order to roll GN ac799c2fd5..b9999d69a9 (r403392:r403866) and pick up the following changes: 511c073 Stop recursion for create_bundle deps when crossing toolchain. 061d24c Fix the script used to roll GN. 4879ced Display outputs for "executable" targets in "gn desc". 3a32f02 GN: Add Windows support to bootstrap.py 3fed805 Fix BundleData::GetBundleRootDirOutput() for non-default toolchain. TBR=dpranke@chromium.org Committed: https://crrev.com/587210e9f83308705f4dd045aa10042afe62a63a Cr-Commit-Position: refs/heads/master@{#403886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
4 years, 5 months ago (2016-07-06 09:18:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123163002/1
4 years, 5 months ago (2016-07-06 09:18:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 11:51:47 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/587210e9f83308705f4dd045aa10042afe62a63a Cr-Commit-Position: refs/heads/master@{#403886}
4 years, 5 months ago (2016-07-06 11:55:11 UTC) #6
Dirk Pranke
4 years, 5 months ago (2016-07-06 17:43:56 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698