Make video quality test fail cleaner if video hasn't started yet.

Make video quality test fail cleaner if video hasn't started yet.

Video must be playing when the onplay handler gets called, and
the test detects that. This patch makes the test fail faster in
that situation though; it used to return still-capturing up to
timeout when capturing had already failed. This change will
make it immediately return failure.

BUG=625943
Committed: https://crrev.com/36b4a432027b5634fce7c4a5566b86694f750ac4
Cr-Commit-Position: refs/heads/master@{#404145}

[phoglund_chromium, 2016-07-06 12:15:08]

phoglund@chromium.org changed reviewers:
+ pbos@chromium.org

[phoglund_chromium, 2016-07-07 08:11:54]

Description was changed from

==========
Make video quality test fail cleaner if video was 0x0.

Earlier we would return still-capturing after failing, but this doesn't
make any sense since capturing has failed. This change makes us fail
the test right away.

BUG=625943
==========

to

==========
Make video quality test retry if video hasn't started yet.

The fix to crbug.com/403710 means there is no longer any
guarantee that video is actually playing when an onplay
handler is invoked. Make the test retry in these cases.
The use of text statuses should make it clear what's going
on in the cases where we never get video (the test will
print waiting-for-video-to-start repeatedly in these 
cases).

BUG=625943
==========

[phoglund_chromium, 2016-07-07 08:11:54]

phoglund@chromium.org changed reviewers:
+ guidou@chromium.org
- pbos@chromium.org

[Guido Urdaneta, 2016-07-07 08:44:53]

lgtm, although we should continue the discussion about what the correct
semantics for onplay are.

[Guido Urdaneta, 2016-07-07 11:21:18]

On 2016/07/07 08:44:53, Guido Urdaneta wrote:
> lgtm, although we should continue the discussion about what the correct
> semantics for onplay are.

we checked the spec and concluded that we should know the dimensions of the
video by the time onplay is fired, so let's not land the test, but revert the
offending CL.

[phoglund_chromium, 2016-07-07 11:53:20]

Description was changed from

==========
Make video quality test retry if video hasn't started yet.

The fix to crbug.com/403710 means there is no longer any
guarantee that video is actually playing when an onplay
handler is invoked. Make the test retry in these cases.
The use of text statuses should make it clear what's going
on in the cases where we never get video (the test will
print waiting-for-video-to-start repeatedly in these 
cases).

BUG=625943
==========

to

==========
Make video quality test fail cleaner if video hasn't started yet.

Video must be playing when the onplay handler gets called, and
the test detects that. This patch makes the test fail faster in
that situation though; it used to return still-capturing up to
timeout when capturing had already failed. This change will
make it immediately return failure.

BUG=625943
==========

[phoglund_chromium, 2016-07-07 11:53:51]

Ok, I have repurposed the patch to report errors better; please take another
look.

[Guido Urdaneta, 2016-07-07 11:56:57]

On 2016/07/07 11:53:51, phoglund_chrome wrote:
> Ok, I have repurposed the patch to report errors better; please take another
> look.

lgtm

[phoglund_chromium, 2016-07-07 12:08:18]

The CQ bit was checked by phoglund@chromium.org

[commit-bot: I haz the power, 2016-07-07 12:08:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 13:29:43]

Description was changed from

==========
Make video quality test fail cleaner if video hasn't started yet.

Video must be playing when the onplay handler gets called, and
the test detects that. This patch makes the test fail faster in
that situation though; it used to return still-capturing up to
timeout when capturing had already failed. This change will
make it immediately return failure.

BUG=625943
==========

to

==========
Make video quality test fail cleaner if video hasn't started yet.

Video must be playing when the onplay handler gets called, and
the test detects that. This patch makes the test fail faster in
that situation though; it used to return still-capturing up to
timeout when capturing had already failed. This change will
make it immediately return failure.

BUG=625943
==========

[commit-bot: I haz the power, 2016-07-07 13:29:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-07 13:29:46]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 13:31:11]

Description was changed from

==========
Make video quality test fail cleaner if video hasn't started yet.

Video must be playing when the onplay handler gets called, and
the test detects that. This patch makes the test fail faster in
that situation though; it used to return still-capturing up to
timeout when capturing had already failed. This change will
make it immediately return failure.

BUG=625943
==========

to

==========
Make video quality test fail cleaner if video hasn't started yet.

Video must be playing when the onplay handler gets called, and
the test detects that. This patch makes the test fail faster in
that situation though; it used to return still-capturing up to
timeout when capturing had already failed. This change will
make it immediately return failure.

BUG=625943

Committed: https://crrev.com/36b4a432027b5634fce7c4a5566b86694f750ac4
Cr-Commit-Position: refs/heads/master@{#404145}
==========

[commit-bot: I haz the power, 2016-07-07 13:31:13]

Patchset 3 (id:??) landed as
https://crrev.com/36b4a432027b5634fce7c4a5566b86694f750ac4
Cr-Commit-Position: refs/heads/master@{#404145}