Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2123133002: Storage manager: Add site data size on the amount of browsing data. (Closed)

Created:
4 years, 5 months ago by fukino
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Storage manager: Add site data size on the amount of browsing data. The size of browsing data used to contain only HTTP cache. This CL adds the total size of site data as a part of browsing data. BUG=625072 TEST=manually tested Committed: https://crrev.com/bace6ed0fd91cd357569dc9ad1d285ff2390520e Cr-Commit-Position: refs/heads/master@{#404320}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Show "Unknown" when getting browsing data fails. #

Patch Set 3 : Add a missing header. #

Total comments: 4

Patch Set 4 : Use 2 ints and 2 bools to track fetched browsing data size. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -19 lines) Patch
M chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h View 1 2 3 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc View 1 2 3 7 chunks +73 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
fukino
Dan, could you take a look? Thanks!
4 years, 5 months ago (2016-07-06 08:57:16 UTC) #3
Dan Beam
lgtm w/nits https://codereview.chromium.org/2123133002/diff/1/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc File chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc (right): https://codereview.chromium.org/2123133002/diff/1/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc#newcode317 chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc:317: if (browser_site_data_size_ >= 0 && browser_cache_size_ >= ...
4 years, 5 months ago (2016-07-06 18:29:22 UTC) #4
fukino
Could you take another look? I made a non-trivial change on this CL to update ...
4 years, 5 months ago (2016-07-07 11:08:18 UTC) #5
Dan Beam
i'm fine with this implementation, but 2 bools and 2 ints sure did seem simpler... ...
4 years, 5 months ago (2016-07-07 18:46:23 UTC) #6
fukino
Though I was thinking of a possibility of future expansion, I don't have any plan ...
4 years, 5 months ago (2016-07-08 03:47:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123133002/60001
4 years, 5 months ago (2016-07-08 04:25:28 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-08 09:28:58 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 09:32:25 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bace6ed0fd91cd357569dc9ad1d285ff2390520e
Cr-Commit-Position: refs/heads/master@{#404320}

Powered by Google App Engine
This is Rietveld 408576698