Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 212313003: Revert of Use the system provided harfbuzz on chromeos (Closed)

Created:
6 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Use the system provided harfbuzz on chromeos (https://codereview.chromium.org/203163003/) Reason for revert: chromeos doesn't have hb-icu.h Original issue's description: > Use the system provided harfbuzz on chromeos > > It's part of the pango library we use already, so by using it, we avoid > a link time collission. > > However, if you build just the browser on linux on ubuntu 12, we don't > have such an up to date pango available, so we need to be a bit smart > about whether or not to use the system harfbuzz. > > This also allows for treating linker warnings as errors on chromeos > > BUG=353127 > R=jshin@chromium.org, thakis@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259423 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259530 TBR=jshin@chromium.org,thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=353127 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -237 lines) Patch
D build/check_return_value.py View 1 chunk +0 lines, -15 lines 0 comments Download
M build/common.gypi View 10 chunks +20 lines, -26 lines 0 comments Download
M third_party/harfbuzz-ng/harfbuzz.gyp View 1 chunk +133 lines, -196 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Use the system provided harfbuzz on chromeos
6 years, 9 months ago (2014-03-26 09:30:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/212313003/1
6 years, 9 months ago (2014-03-26 09:30:42 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 09:31:33 UTC) #3
Message was sent while issue was closed.
Change committed as 259534

Powered by Google App Engine
This is Rietveld 408576698