Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 21231003: Update third_party/protobuf to r428, part 2 (Closed)

Created:
7 years, 4 months ago by Alexander Potapenko
Modified:
7 years, 4 months ago
Reviewers:
nyquist, Philippe, agl, pliard
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Visibility:
Public.

Description

Update third_party/protobuf to r428, part 2 This CL contains the leftover files which aren't used by Chrome. (Part 1 is at https://codereview.chromium.org/21208003/) These files have been merged from upstream automatically. BUG=259808

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9303 lines, -495 lines) Patch
M third_party/protobuf/CHANGES.txt View 1 2 1 chunk +58 lines, -0 lines 0 comments Download
M third_party/protobuf/java/src/test/java/com/google/protobuf/AbstractMessageTest.java View 1 2 6 chunks +50 lines, -1 line 0 comments Download
A third_party/protobuf/java/src/test/java/com/google/protobuf/BoundedByteStringTest.java View 1 chunk +68 lines, -0 lines 0 comments Download
A third_party/protobuf/java/src/test/java/com/google/protobuf/ByteStringTest.java View 1 chunk +692 lines, -0 lines 0 comments Download
M third_party/protobuf/java/src/test/java/com/google/protobuf/CodedOutputStreamTest.java View 1 2 2 chunks +8 lines, -9 lines 0 comments Download
M third_party/protobuf/java/src/test/java/com/google/protobuf/DescriptorsTest.java View 1 2 5 chunks +190 lines, -2 lines 0 comments Download
M third_party/protobuf/java/src/test/java/com/google/protobuf/DynamicMessageTest.java View 1 2 4 chunks +55 lines, -17 lines 0 comments Download
M third_party/protobuf/java/src/test/java/com/google/protobuf/GeneratedMessageTest.java View 1 2 5 chunks +167 lines, -1 line 0 comments Download
A third_party/protobuf/java/src/test/java/com/google/protobuf/IsValidUtf8Test.java View 1 chunk +180 lines, -0 lines 0 comments Download
A third_party/protobuf/java/src/test/java/com/google/protobuf/IsValidUtf8TestUtil.java View 1 chunk +421 lines, -0 lines 0 comments Download
M third_party/protobuf/java/src/test/java/com/google/protobuf/LazyStringArrayListTest.java View 1 2 2 chunks +44 lines, -0 lines 0 comments Download
M third_party/protobuf/java/src/test/java/com/google/protobuf/LazyStringEndToEndTest.java View 1 2 2 chunks +28 lines, -0 lines 0 comments Download
A third_party/protobuf/java/src/test/java/com/google/protobuf/LiteralByteStringTest.java View 1 chunk +396 lines, -0 lines 0 comments Download
M third_party/protobuf/java/src/test/java/com/google/protobuf/MessageTest.java View 1 2 2 chunks +40 lines, -0 lines 0 comments Download
A third_party/protobuf/java/src/test/java/com/google/protobuf/ParserTest.java View 1 chunk +375 lines, -0 lines 0 comments Download
A third_party/protobuf/java/src/test/java/com/google/protobuf/RopeByteStringSubstringTest.java View 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/protobuf/java/src/test/java/com/google/protobuf/RopeByteStringTest.java View 1 chunk +115 lines, -0 lines 0 comments Download
M third_party/protobuf/java/src/test/java/com/google/protobuf/TestBadIdentifiers.java View 1 2 2 chunks +16 lines, -2 lines 0 comments Download
M third_party/protobuf/java/src/test/java/com/google/protobuf/TestUtil.java View 1 2 67 chunks +177 lines, -33 lines 0 comments Download
M third_party/protobuf/java/src/test/java/com/google/protobuf/TextFormatTest.java View 1 2 2 chunks +34 lines, -0 lines 0 comments Download
M third_party/protobuf/java/src/test/java/com/google/protobuf/WireFormatTest.java View 1 2 4 chunks +155 lines, -2 lines 0 comments Download
M third_party/protobuf/java/src/test/java/com/google/protobuf/test_bad_identifiers.proto View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
A third_party/protobuf/python/google/protobuf/internal/descriptor_database_test.py View 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/protobuf/python/google/protobuf/internal/descriptor_pool_test.py View 1 chunk +220 lines, -0 lines 0 comments Download
M third_party/protobuf/python/google/protobuf/internal/descriptor_test.py View 1 2 6 chunks +279 lines, -0 lines 0 comments Download
A third_party/protobuf/python/google/protobuf/internal/factory_test1.proto View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/protobuf/python/google/protobuf/internal/factory_test2.proto View 1 chunk +77 lines, -0 lines 0 comments Download
M third_party/protobuf/python/google/protobuf/internal/generator_test.py View 1 2 2 chunks +25 lines, -0 lines 0 comments Download
A third_party/protobuf/python/google/protobuf/internal/message_cpp_test.py View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/protobuf/python/google/protobuf/internal/message_factory_test.py View 1 chunk +113 lines, -0 lines 0 comments Download
M third_party/protobuf/python/google/protobuf/internal/message_test.py View 1 2 13 chunks +166 lines, -15 lines 0 comments Download
A third_party/protobuf/python/google/protobuf/internal/reflection_cpp_generated_test.py View 1 chunk +91 lines, -0 lines 0 comments Download
M third_party/protobuf/python/google/protobuf/internal/reflection_test.py View 1 2 15 chunks +269 lines, -19 lines 0 comments Download
A third_party/protobuf/python/google/protobuf/internal/test_bad_identifiers.proto View 1 chunk +52 lines, -0 lines 0 comments Download
M third_party/protobuf/python/google/protobuf/internal/test_util.py View 1 2 11 chunks +18 lines, -2 lines 0 comments Download
M third_party/protobuf/python/google/protobuf/internal/text_format_test.py View 1 2 7 chunks +40 lines, -14 lines 0 comments Download
A third_party/protobuf/python/google/protobuf/internal/unknown_fields_test.py View 1 chunk +170 lines, -0 lines 0 comments Download
M third_party/protobuf/src/Makefile.am View 1 2 10 chunks +22 lines, -2 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/compiler/command_line_interface_unittest.cc View 1 2 8 chunks +114 lines, -6 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_bootstrap_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_test_bad_identifiers.proto View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_unittest.h View 1 chunk +51 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_unittest.cc View 1 2 8 chunks +72 lines, -3 lines 0 comments Download
A third_party/protobuf/src/google/protobuf/compiler/java/java_doc_comment_unittest.cc View 1 chunk +66 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/compiler/parser_unittest.cc View 1 2 43 chunks +510 lines, -258 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/descriptor_unittest.cc View 1 2 28 chunks +661 lines, -41 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/dynamic_message_unittest.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/extension_set_unittest.cc View 1 2 6 chunks +86 lines, -6 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/generated_message_reflection_unittest.cc View 1 2 2 chunks +100 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/io/coded_stream_unittest.cc View 1 2 4 chunks +61 lines, -1 line 0 comments Download
M third_party/protobuf/src/google/protobuf/io/printer_unittest.cc View 1 2 1 chunk +25 lines, -1 line 0 comments Download
M third_party/protobuf/src/google/protobuf/io/tokenizer_unittest.cc View 1 2 6 chunks +238 lines, -3 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/io/zero_copy_stream_unittest.cc View 1 2 1 chunk +94 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/lite_unittest.cc View 1 2 2 chunks +74 lines, -1 line 0 comments Download
M third_party/protobuf/src/google/protobuf/message_unittest.cc View 1 2 2 chunks +73 lines, -0 lines 0 comments Download
A third_party/protobuf/src/google/protobuf/repeated_field_reflection_unittest.cc View 1 chunk +193 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/repeated_field_unittest.cc View 1 2 29 chunks +313 lines, -40 lines 0 comments Download
A third_party/protobuf/src/google/protobuf/stubs/stringprintf_unittest.cc View 1 1 chunk +152 lines, -0 lines 0 comments Download
A third_party/protobuf/src/google/protobuf/stubs/template_util_unittest.cc View 1 chunk +130 lines, -0 lines 0 comments Download
A third_party/protobuf/src/google/protobuf/stubs/type_traits_unittest.cc View 1 chunk +647 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/testdata/text_format_unittest_data.txt View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/testdata/text_format_unittest_extensions_data.txt View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/text_format_unittest.cc View 1 2 5 chunks +102 lines, -2 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/unittest.proto View 1 2 9 chunks +88 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/unittest_custom_options.proto View 1 2 2 chunks +21 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/unittest_import.proto View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/unittest_import_lite.proto View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/protobuf/src/google/protobuf/unittest_import_public.proto View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/protobuf/src/google/protobuf/unittest_import_public_lite.proto View 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/unittest_lite.proto View 1 2 5 chunks +48 lines, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/unknown_field_set_unittest.cc View 1 2 5 chunks +85 lines, -3 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/wire_format_unittest.cc View 1 2 6 chunks +83 lines, -10 lines 0 comments Download
M third_party/protobuf/vsprojects/extract_includes.bat View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexander Potapenko
Please take a look.
7 years, 4 months ago (2013-07-31 16:15:18 UTC) #1
pliard
rubberstamp lgtm
7 years, 4 months ago (2013-08-06 11:53:15 UTC) #2
agl
lgtm
7 years, 4 months ago (2013-08-06 14:39:22 UTC) #3
Alexander Potapenko
7 years, 4 months ago (2013-08-12 09:08:14 UTC) #4 
On 2013/08/06 14:39:22, agl wrote:
> lgtm

This has been committed together with part 1 in
https://codereview.chromium.org/21208003/
Closing the issue.

Powered by Google App Engine
This is Rietveld 408576698