Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2123093009: Rietveld: add CQ status URL instead of comment. (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
Reviewers:
Bons, rmistry1, emso
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Rietveld: add CQ status URL instead of comment. BUG=596249 Committed: https://chromium.googlesource.com/infra/infra/+/9a9c7be53ad1cc67f4492554feebf256c7972f50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -0 lines) Patch
M appengine/chromium_rietveld/codereview/models.py View 2 chunks +22 lines, -0 lines 0 comments Download
M appengine/chromium_rietveld/codereview/utils.py View 2 chunks +21 lines, -0 lines 0 comments Download
M appengine/chromium_rietveld/codereview/views.py View 1 chunk +4 lines, -0 lines 0 comments Download
M appengine/chromium_rietveld/templates/patchset.html View 1 chunk +3 lines, -0 lines 0 comments Download
A appengine/chromium_rietveld/tests/test_utils.py View 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
tandrii(chromium)
PTAL Example from my local test: https://screenshot.googleplex.com/uot4XBv4bNm This is a hack, of course. In my ...
4 years, 5 months ago (2016-07-07 19:05:32 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123093009/1
4 years, 5 months ago (2016-07-07 19:06:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 19:22:08 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123093009/1
4 years, 5 months ago (2016-07-07 19:31:05 UTC) #8
emso
lgtm
4 years, 5 months ago (2016-07-08 10:36:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123093009/1
4 years, 5 months ago (2016-07-08 10:48:32 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 10:50:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/9a9c7be53ad1cc67f4492554feebf...

Powered by Google App Engine
This is Rietveld 408576698